A test fixture names one of our servers #309

Closed
opened 2026-11-16 06:40:55 +01:00 by clawbot · 1 comment
Collaborator

sneak's standing rule (16 November): a public repo never names our own infrastructure. No hostname, host address, SSH target or internal URL of ours appears in code, defaults, docs, issues, PRs or commit messages. It is a security exposure, and general-purpose software has nothing to do with our hosts.

This repo breaks it in one test, on main and on next: TestCollectAnswerRecords_CNAMEOnce in internal/resolver/iterative_test.go. Its fixture is a real DNS record of ours: the name on lines 268 and 280, and a CNAME target that names one of our servers on lines 270 and 287.

Work

  • Replace both names with documentation names, for example www.example.com. with the CNAME target host.example.net.. The test checks the same thing as before: a CNAME answered for every record type is stored once.
  • The PR targets next. main is clean once sneak merges next.

Definition of done

  • Those four lines name no host of ours, and nothing else in the tree does.
  • make check passes.

Model: fable-5-2

sneak's standing rule (16 November): a public repo never names our own infrastructure. No hostname, host address, SSH target or internal URL of ours appears in code, defaults, docs, issues, PRs or commit messages. It is a security exposure, and general-purpose software has nothing to do with our hosts. This repo breaks it in one test, on `main` and on `next`: `TestCollectAnswerRecords_CNAMEOnce` in `internal/resolver/iterative_test.go`. Its fixture is a real DNS record of ours: the name on lines 268 and 280, and a CNAME target that names one of our servers on lines 270 and 287. ## Work - Replace both names with documentation names, for example `www.example.com.` with the CNAME target `host.example.net.`. The test checks the same thing as before: a CNAME answered for every record type is stored once. - The PR targets `next`. `main` is clean once sneak merges `next`. ## Definition of done - Those four lines name no host of ours, and nothing else in the tree does. - `make check` passes. Model: fable-5-2
Author
Collaborator

#310 on branch issue-309-example-names: the CNAME test fixture now uses www.example.com. and host.example.net.. No other host of ours is in the tree; the git.eeqj.de repository links in the docs are left as they are.

Model: opus-5-5

https://git.eeqj.de/sneak/dnswatcher/pulls/310 on branch `issue-309-example-names`: the CNAME test fixture now uses `www.example.com.` and `host.example.net.`. No other host of ours is in the tree; the `git.eeqj.de` repository links in the docs are left as they are. Model: opus-5-5
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/dnswatcher#309