sneak/dnswatcher
1
0
Fork 0
Code Issues 3 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix: mock DNS client in resolver tests (replaces PR #25) #27

Closed
clawbot wants to merge 1 commits from fix/mock-resolver-tests into main
pull from: fix/mock-resolver-tests
merge into: sneak:main
Conversation 0 Commits 1 Files Changed 1 +390 -70
clawbot commented 2026-02-21 11:57:36 +01:00
Collaborator
Copy Link

Problem

Resolver tests did real iterative DNS lookups from root nameservers, causing make check to hang/take >30s.

PR #25 tried to fix this by adding -short to skip tests — that's wrong (same as weakening linter config).

Solution

Mock the DNSClient interface in tests using canned responses. Uses the existing NewFromLoggerWithClient constructor — no production code changes.

  • All 29 resolver tests pass in ~1s with zero network calls
  • make check passes with 0 issues
  • No -short flags, no skipped tests, no Makefile changes

make check output

==> Checking formatting...
==> Running linter...
0 issues.
==> Running tests...
ok  sneak.berlin/go/dnswatcher/internal/resolver  1.192s
==> All checks passed!

Closes #25 approach — this is the correct fix.

## Problem Resolver tests did real iterative DNS lookups from root nameservers, causing `make check` to hang/take >30s. PR #25 tried to fix this by adding `-short` to skip tests — that's wrong (same as weakening linter config). ## Solution Mock the `DNSClient` interface in tests using canned responses. Uses the existing `NewFromLoggerWithClient` constructor — no production code changes. - All 29 resolver tests pass in ~1s with zero network calls - `make check` passes with 0 issues - No `-short` flags, no skipped tests, no Makefile changes ## `make check` output ``` ==> Checking formatting... ==> Running linter... 0 issues. ==> Running tests... ok sneak.berlin/go/dnswatcher/internal/resolver 1.192s ==> All checks passed! ``` Closes #25 approach — this is the correct fix.
sneak was assigned by clawbot 2026-02-21 11:57:36 +01:00
clawbot added 1 commit 2026-02-21 11:57:37 +01:00
fix: mock DNS client in resolver tests to avoid network calls
All checks were successful
Check / check (pull_request) Successful in 10m10s
Details
9b93385f6f 
Replace real DNS lookups in resolver_test.go with a mock DNSClient
that returns canned responses. Tests now run in ~1s instead of >30s
with no network dependency.

Uses the existing NewFromLoggerWithClient constructor and DNSClient
interface — no production code changes needed.
clawbot closed this pull request 2026-02-21 11:58:05 +01:00
Some checks are pending
Check / check (pull_request) Successful in 10m10s
Details
check / check (push)
Required

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bot
Agent's turn to work
 merge-ready
All checks pass, reviewed, rebased, ready for merge
 needs-checks
make check does not pass cleanly
 needs-rebase
PR has merge conflicts or is behind main
 needs-review
Code review not yet done
 needs-rework
Code review found issues to fix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
clawbot sneak
No Assignees sneak
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/dnswatcher#27
Delete Branch "fix/mock-resolver-tests"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?