sneak/dnswatcher
1
0
Fork 0
Code Issues 3 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix: skip real-DNS resolver tests in make check, add timeout (closes #24) #25

Closed
clawbot wants to merge 1 commits from fix/make-check-resolver-tests into main
pull from: fix/make-check-resolver-tests
merge into: sneak:main
Conversation 0 Commits 1 Files Changed 2 +7 -3
clawbot commented 2026-02-21 11:37:59 +01:00
Collaborator
Copy Link

Problem

make check hangs on main because resolver tests do real iterative DNS from root servers.

Changes

  • Add -short and -timeout 30s to go test in make check
  • Skip network-dependent tests when -short is set (via testContext helper)
  • Context-canceled tests still run (no network needed)
  • Also add -timeout 30s to make test

make check output

==> Checking formatting... OK
==> Running linter... 0 issues
==> Running tests... PASS (all packages, ~8s total)
==> Building... OK
==> All checks passed!

Completes in <10 seconds.

## Problem `make check` hangs on main because resolver tests do real iterative DNS from root servers. ## Changes - Add `-short` and `-timeout 30s` to `go test` in `make check` - Skip network-dependent tests when `-short` is set (via `testContext` helper) - Context-canceled tests still run (no network needed) - Also add `-timeout 30s` to `make test` ## make check output ``` ==> Checking formatting... OK ==> Running linter... 0 issues ==> Running tests... PASS (all packages, ~8s total) ==> Building... OK ==> All checks passed! ``` Completes in <10 seconds.
sneak was assigned by clawbot 2026-02-21 11:37:59 +01:00
clawbot added 1 commit 2026-02-21 11:38:00 +01:00
fix: skip real-DNS resolver tests in make check, add timeout
All checks were successful
Check / check (pull_request) Successful in 10m9s
Details
a2819c34d9 
Resolver tests perform iterative DNS resolution from root nameservers,
which can hang indefinitely. This broke make check on main.

Changes:
- Add -short and -timeout 30s flags to go test in make check
- Skip real-DNS integration tests when -short is set (via testContext helper)
- Context-canceled tests still run (no network needed)
- Also add -timeout 30s to make test target

Run integration tests explicitly with: go test -v -race ./internal/resolver/...
clawbot closed this pull request 2026-02-21 11:58:04 +01:00
Some checks are pending
Check / check (pull_request) Successful in 10m9s
Details
check / check (push)
Required

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bot
Agent's turn to work
 merge-ready
All checks pass, reviewed, rebased, ready for merge
 needs-checks
make check does not pass cleanly
 needs-rebase
PR has merge conflicts or is behind main
 needs-review
Code review not yet done
 needs-rework
Code review found issues to fix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
clawbot sneak
No Assignees sneak
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/dnswatcher#25
Delete Branch "fix/make-check-resolver-tests"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?