make check hangs on main because resolver tests do real iterative DNS from root servers.
Changes
Add -short and -timeout 30s to go test in make check
Skip network-dependent tests when -short is set (via testContext helper)
Context-canceled tests still run (no network needed)
Also add -timeout 30s to make test
make check output
==> Checking formatting... OK
==> Running linter... 0 issues
==> Running tests... PASS (all packages, ~8s total)
==> Building... OK
==> All checks passed!
Completes in <10 seconds.
## Problem
`make check` hangs on main because resolver tests do real iterative DNS from root servers.
## Changes
- Add `-short` and `-timeout 30s` to `go test` in `make check`
- Skip network-dependent tests when `-short` is set (via `testContext` helper)
- Context-canceled tests still run (no network needed)
- Also add `-timeout 30s` to `make test`
## make check output
```
==> Checking formatting... OK
==> Running linter... 0 issues
==> Running tests... PASS (all packages, ~8s total)
==> Building... OK
==> All checks passed!
```
Completes in <10 seconds.
sneak
was assigned by clawbot2026-02-21 11:37:59 +01:00
Resolver tests perform iterative DNS resolution from root nameservers,
which can hang indefinitely. This broke make check on main.
Changes:
- Add -short and -timeout 30s flags to go test in make check
- Skip real-DNS integration tests when -short is set (via testContext helper)
- Context-canceled tests still run (no network needed)
- Also add -timeout 30s to make test target
Run integration tests explicitly with: go test -v -race ./internal/resolver/...
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Problem
make checkhangs on main because resolver tests do real iterative DNS from root servers.Changes
-shortand-timeout 30stogo testinmake check-shortis set (viatestContexthelper)-timeout 30stomake testmake check output
Completes in <10 seconds.
Pull request closed