A Port Change notification's Hosts: line listed a port's apex domains and its hostnames together. It now lists them on a Domains: line and a Hostnames: line, followed by Address: and Port now ... as before:
Domains: example.net
Hostnames: www.example.net
Address: 192.0.2.1:443
Port now closed
A name is a domain when it is a configured domain. That is the rule record notifications use to start Domain: or Hostname: (#244). The rule is now one method, isDomain, which both use. README's Port Change description says so, and a new watcher test checks the message for a domain and a hostname on the same port. The test builds saved state and looks nothing up.
What the diff does not show: a port entry in the state file still lists domains under hostnames, as README's State File Format says. Only the notification changed.
Judgement call: a line with no names is left out, so a port that only hostnames resolve to has no Domains: line.
Judgement call: both labels are plural even for one name, like the dashboard's Ports columns and the /api/v1/status port lists.
Model: opus-5-5
Closes https://git.eeqj.de/sneak/dnswatcher/issues/248
A Port Change notification's `Hosts:` line listed a port's apex domains and its hostnames together. It now lists them on a `Domains:` line and a `Hostnames:` line, followed by `Address:` and `Port now ...` as before:
```
Domains: example.net
Hostnames: www.example.net
Address: 192.0.2.1:443
Port now closed
```
A name is a domain when it is a configured domain. That is the rule record notifications use to start `Domain:` or `Hostname:` (https://git.eeqj.de/sneak/dnswatcher/pulls/244). The rule is now one method, `isDomain`, which both use. README's Port Change description says so, and a new watcher test checks the message for a domain and a hostname on the same port. The test builds saved state and looks nothing up.
What the diff does not show: a port entry in the state file still lists domains under `hostnames`, as README's State File Format says. Only the notification changed.
Judgement call: a line with no names is left out, so a port that only hostnames resolve to has no `Domains:` line.
Judgement call: both labels are plural even for one name, like the dashboard's Ports columns and the `/api/v1/status` port lists.
Model: opus-5-5
A Port Change notification's `Hosts:` line listed a port's apex domains
and hostnames together. It now has a `Domains:` line and a `Hostnames:`
line, and leaves out one that would name nothing. A name is a domain
when it is a configured domain, the rule record notifications already
use to start `Domain:` or `Hostname:`; that rule is now one method,
isDomain, which both use. The port entries saved in the state are
unchanged. README describes the new lines.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Closes #248
A Port Change notification's
Hosts:line listed a port's apex domains and its hostnames together. It now lists them on aDomains:line and aHostnames:line, followed byAddress:andPort now ...as before:A name is a domain when it is a configured domain. That is the rule record notifications use to start
Domain:orHostname:(#244). The rule is now one method,isDomain, which both use. README's Port Change description says so, and a new watcher test checks the message for a domain and a hostname on the same port. The test builds saved state and looks nothing up.What the diff does not show: a port entry in the state file still lists domains under
hostnames, as README's State File Format says. Only the notification changed.Judgement call: a line with no names is left out, so a port that only hostnames resolve to has no
Domains:line.Judgement call: both labels are plural even for one name, like the dashboard's Ports columns and the
/api/v1/statusport lists.Model: opus-5-5
Review passed on
5388a11.Model: opus-5-5