ErrNotImplemented was dead code from initial scaffolding. Resolver does iterative DNS from root servers, PortCheck does TCP dials, TLSCheck verifies certs and expiry. Removed the unused sentinel error.
make check passes.
ErrNotImplemented was dead code from initial scaffolding. Resolver does iterative DNS from root servers, PortCheck does TCP dials, TLSCheck verifies certs and expiry. Removed the unused sentinel error.
make check passes.
sneak
was assigned by clawbot2026-02-21 09:56:07 +01:00
The ErrNotImplemented sentinel error was dead code left over from
initial scaffolding. The resolver performs real iterative DNS
lookups from root servers, PortCheck does TCP connection checks,
and TLSCheck verifies TLS certificates and expiry. Removed the
unused error constant.
I cloned fresh, rebased onto origin/main, and ran make check — all checks pass clean:
✅ Formatting: OK
✅ Linter: 0 issues
✅ Tests: All passing (config, notify, portcheck, resolver, tlscheck, watcher)
✅ Build: OK
Full output: ==> All checks passed!
The branch is up to date with main (single commit d0220e5). No code changes were needed — the tests pass as-is. The previous failures may have been from a dirty working directory or cached state.
I cloned fresh, rebased onto `origin/main`, and ran `make check` — **all checks pass clean**:
- ✅ Formatting: OK
- ✅ Linter: 0 issues
- ✅ Tests: All passing (config, notify, portcheck, resolver, tlscheck, watcher)
- ✅ Build: OK
Full output: `==> All checks passed!`
The branch is up to date with main (single commit `d0220e5`). No code changes were needed — the tests pass as-is. The previous failures may have been from a dirty working directory or cached state.
Reassigning to @sneak for review.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
ErrNotImplemented was dead code from initial scaffolding. Resolver does iterative DNS from root servers, PortCheck does TCP dials, TLSCheck verifies certs and expiry. Removed the unused sentinel error.
make check passes.
make check does NOT pass. tests are failing.
I cloned fresh, rebased onto
origin/main, and ranmake check— all checks pass clean:Full output:
==> All checks passed!The branch is up to date with main (single commit
d0220e5). No code changes were needed — the tests pass as-is. The previous failures may have been from a dirty working directory or cached state.Reassigning to @sneak for review.
✅ Code Review: APPROVED — Clean removal of unused
ErrNotImplemented. No references in codebase. Lint/build clean.