CRITICAL: Resolver, PortCheck, and TLSCheck are unimplemented stubs #16

New Issue

2026-02-20T13:49:40+01:00

clawbot commented

2026-02-20 13:49:40 +01:00

Bug

All three core service implementations return ErrNotImplemented:

internal/resolver/resolver.go — LookupNS, LookupAllRecords, ResolveIPAddresses all return ErrNotImplemented
internal/portcheck/portcheck.go — CheckPort returns ErrNotImplemented
internal/tlscheck/tlscheck.go — CheckCertificate returns ErrNotImplemented

Impact

The application starts successfully and appears healthy (HTTP server responds, health endpoint returns ok), but performs zero actual monitoring. Every DNS lookup fails silently (error is logged but no notification sent), so no hostname state is ever populated, meaning port checks and TLS checks also never run.

This is the #1 blocker for 1.0 — the app literally does not do what it claims to do.

Fix

Implement all three services. The resolver should perform iterative DNS resolution from root servers (or at minimum use the system resolver). The port checker should do TCP connect. The TLS checker should do a TLS handshake with SNI and extract certificate info.

## Bug All three core service implementations return `ErrNotImplemented`: - `internal/resolver/resolver.go` — `LookupNS`, `LookupAllRecords`, `ResolveIPAddresses` all return `ErrNotImplemented` - `internal/portcheck/portcheck.go` — `CheckPort` returns `ErrNotImplemented` - `internal/tlscheck/tlscheck.go` — `CheckCertificate` returns `ErrNotImplemented` ## Impact The application starts successfully and appears healthy (HTTP server responds, health endpoint returns ok), but performs zero actual monitoring. Every DNS lookup fails silently (error is logged but no notification sent), so no hostname state is ever populated, meaning port checks and TLS checks also never run. This is the #1 blocker for 1.0 — the app literally does not do what it claims to do. ## Fix Implement all three services. The resolver should perform iterative DNS resolution from root servers (or at minimum use the system resolver). The port checker should do TCP connect. The TLS checker should do a TLS handshake with SNI and extract certificate info.

clawbot referenced this issue from a commit

2026-02-21 09:55:40 +01:00

fix: remove ErrNotImplemented stub — resolver, port, and TLS checks are fully implemented (closes #16)

clawbot referenced a pull request that will close this issue

2026-02-21 09:56:07 +01:00

fix: remove ErrNotImplemented stub — all checks fully implemented (closes #16) #23

sneak closed this issue

2026-02-28 12:26:27 +01:00

sneak referenced this issue from a commit

2026-02-28 12:26:28 +01:00

Merge pull request 'fix: remove ErrNotImplemented stub — all checks fully implemented (closes #16)' (#23) from fix/remove-unimplemented-stubs into main

Sign in to join this conversation.