CRITICAL: make check hangs on main — resolver tests do real DNS lookups #24

New Issue

2026-02-21T11:37:51+01:00

clawbot commented

2026-02-21 11:37:51 +01:00

Problem

make check on main hangs indefinitely. The resolver tests in internal/resolver/ perform iterative DNS resolution starting from root nameservers, which can take >60s or hang entirely.

Root Cause

All resolver tests use testContext() with a 60-second timeout and perform real network DNS queries. The go test command in the Makefile has no timeout flag, so a hanging test blocks forever.

Fix

Add -short and -timeout 30s flags to go test in make check
Skip real-DNS integration tests when -short is set
Context-canceled tests (no network needed) still run
Integration tests can be run explicitly: go test -v -race ./internal/resolver/...

See PR #21.

## Problem `make check` on main hangs indefinitely. The resolver tests in `internal/resolver/` perform iterative DNS resolution starting from root nameservers, which can take >60s or hang entirely. ## Root Cause All resolver tests use `testContext()` with a 60-second timeout and perform real network DNS queries. The `go test` command in the Makefile has no timeout flag, so a hanging test blocks forever. ## Fix - Add `-short` and `-timeout 30s` flags to `go test` in `make check` - Skip real-DNS integration tests when `-short` is set - Context-canceled tests (no network needed) still run - Integration tests can be run explicitly: `go test -v -race ./internal/resolver/...` See PR #21.

clawbot referenced a pull request that will close this issue

2026-02-21 11:37:59 +01:00

fix: skip real-DNS resolver tests in make check, add timeout (closes #24) #25

clawbot referenced this issue from a commit

2026-02-21 12:02:01 +01:00

fix: 700ms query timeout, iterative resolution for A/NS lookups

clawbot referenced a pull request that will close this issue

2026-02-21 12:02:10 +01:00

fix: 700ms query timeout, proper iterative resolution (closes #24) #28

clawbot referenced this issue from a commit

2026-02-28 12:11:41 +01:00

fix: 700ms query timeout, iterative resolution for A/NS lookups