Files

T

check / check (push) Successful in 2m12s

Details

Skip excluded paths before looking at their errors (closes #16 )

filepath.Walk hands its callback the error for a path it could not
read, such as a directory it cannot list. Both callbacks, in
walkAndProcess and countFiles, returned that error before they checked
the exclusions, so a directory that --exclude or --exclude-dotfiles
excluded still failed the run when it could not be listed. Given an
error, each callback now checks the exclusions first and skips an
excluded path. The new test excludes a directory that cannot be listed
and runs sum add and check over its parent.

Model: opus-5-5

2026-10-06 03:58:49 +00:00

3.1 KiB

Raw Blame History

Workflow

branch (from main)
do the work in Next Step
move Next Step to the top of Completed Steps
move the top item of Future Steps into Next Step
commit (TODO.md changes in the same commit as the work)
merge to main if the branch is not protected, otherwise open a PR
push

Status

1.0+

Tagged 1.0.0 (2025-05-08). Substantial correctness fixes and features have landed since the tag.

Next Step

Policy scaffold commit: add LICENSE, REPO_POLICIES.md, .editorconfig, .golangci.yml, and a comprehensive .gitignore (currently only the attrsum binary), and extend the Makefile (only test/build/clean/try today) with lint, fmt, fmt-check, check, and hooks targets.

Completed Steps

2026-10-06: a path that --exclude or --exclude-dotfiles excludes is skipped even when it cannot be read, so an excluded directory that cannot be listed no longer fails the run
2026-10-06: check --continue keeps going past a file or directory it cannot read: it counts it as failed, prints the error and the path on stderr, and checks the rest of the tree
2026-10-05: golangci-lint settings take effect: canonical .golangci.yml (v2 layout, settings under linters.settings), golangci-lint pinned at v2.12.2 in Dockerfile and script/bootstrap, and the code fixed for what the settings now report (long lines in attrsum.go rewrapped)
2026-10-05: make try runs on three small files in a temporary directory that it removes afterwards, also when a step fails, instead of on a fixed directory on one person's machine
2026-10-02: attrsum --version reports the git tag or short commit, stamped by make build and by a plain docker build . of a clone; .dockerignore sends .git without .git/config and keeps a host-built attrsum out; CI checks out full history so it stamps the same version
2026-02-02: correctness pass: track actual bytes read instead of stale file size, atomic failure tracking in ProcessCheck, detect file modification during checksum (TOCTOU), propagate countFiles errors, single progress bar across paths, error on empty stdin, dead code removal
2026-02-01: added quiet mode, progress bar, summary report, and stdin path input; multiple file/directory arguments for all commands
2025-07-12: README update
2025-05-08: initial working tool with passing tests, skips non-regular files, Makefile, README; tagged 1.0.0

Future Steps

Add .gitea/workflows/check.yml
Restructure README.md into the standard sections: Description, Getting Started, Rationale, Design, TODO, License, Author (Getting Started, Why?, TODO, License exist; Description, Design, Author are missing)
Tag a patch release to ship the 2026-02-02 correctness fixes
Dry-run mode (--dry-run, -n): show what would be done without making changes (from README TODO)
JSON output (--json) for scripting and integration (from README TODO)
Parallel processing (-j N) with multiple goroutines for faster checksumming on large trees (from README TODO)
Formalize and document exit codes for scripting (from README TODO)