golangci-lint v2 ignores a top-level linters-settings block without a warning, so the settings in .golangci.yml, the 88-column lll limit among them, were never applied.
.golangci.yml is the current canonical copy from sneak/prompts, byte for byte. Its settings live under linters.settings. It also enables gomodguard_v2 and configures depguard, which the August version of this PR did not have.
golangci-lint is pinned at v2.12.2 in Dockerfile and script/bootstrap by commit c0d3ddc9cf3faa61a4e378e879ece580256d76e5 (the commit the v2.12.2 tag points to), with a dated comment.
Long lines in attrsum.go are rewrapped, and one nolint:gosec directive moves to the line above the call it covers. Behaviour is unchanged.
TODO.md gets a Completed Steps entry.
The branch is rebased onto next, and the version stamping there is left as it is.
Deviation: REPO_POLICIES.md pins golangci-lint as the digest of the golangci/golangci-lint image and installs no linter on the host. This PR keeps the go install pins, as the issue asks; #5 moves linting into that image.
Judgement call: the pin date in script/bootstrap is one comment shared by both pins, so it now reads 2026-10-05 for the unchanged goimports pin as well.
Model: opus-5-5
Tracked by https://git.eeqj.de/sneak/attrsum/issues/10.
golangci-lint v2 ignores a top-level `linters-settings` block without a warning, so the settings in `.golangci.yml`, the 88-column `lll` limit among them, were never applied.
- `.golangci.yml` is the current canonical copy from `sneak/prompts`, byte for byte. Its settings live under `linters.settings`. It also enables `gomodguard_v2` and configures `depguard`, which the August version of this PR did not have.
- golangci-lint is pinned at v2.12.2 in `Dockerfile` and `script/bootstrap` by commit `c0d3ddc9cf3faa61a4e378e879ece580256d76e5` (the commit the `v2.12.2` tag points to), with a dated comment.
- Long lines in `attrsum.go` are rewrapped, and one `nolint:gosec` directive moves to the line above the call it covers. Behaviour is unchanged.
- `TODO.md` gets a Completed Steps entry.
The branch is rebased onto `next`, and the version stamping there is left as it is.
Deviation: `REPO_POLICIES.md` pins golangci-lint as the digest of the `golangci/golangci-lint` image and installs no linter on the host. This PR keeps the `go install` pins, as the issue asks; https://git.eeqj.de/sneak/attrsum/issues/5 moves linting into that image.
Judgement call: the pin date in `script/bootstrap` is one comment shared by both pins, so it now reads 2026-10-05 for the unchanged `goimports` pin as well.
Model: opus-5-5
clawbot
self-assigned this 2026-08-10 15:46:33 +02:00
Retargeted from main to next. State: needs-rebase (conflicts with next in TODO.md). Tracked by #10, whose plan comment is the brief for the rebase worker; not dispatched yet.
Model: opus-5-5
Retargeted from `main` to `next`. State: `needs-rebase` (conflicts with `next` in `TODO.md`). Tracked by https://git.eeqj.de/sneak/attrsum/issues/10, whose plan comment is the brief for the rebase worker; not dispatched yet.
Model: opus-5-5
clawbot
changed title from Update golangci-lint to v2.12.2 with canonical config to Make the golangci-lint settings take effect: v2 config layout, linter pinned at v2.12.2 (closes #10)2026-10-06 01:44:59 +02:00
golangci-lint v2 ignores a top-level linters-settings block without a
warning, so limits such as the 88-column line length were never
applied. .golangci.yml is now the canonical copy from sneak/prompts,
verbatim, which keeps its settings under linters.settings and also
configures depguard and gomodguard_v2. golangci-lint is pinned at
v2.12.2 by commit in the Dockerfile and script/bootstrap. The long
lines in attrsum.go are rewrapped and one nolint directive moves to
its own line; behaviour is unchanged.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Tracked by #10.
golangci-lint v2 ignores a top-level
linters-settingsblock without a warning, so the settings in.golangci.yml, the 88-columnllllimit among them, were never applied..golangci.ymlis the current canonical copy fromsneak/prompts, byte for byte. Its settings live underlinters.settings. It also enablesgomodguard_v2and configuresdepguard, which the August version of this PR did not have.Dockerfileandscript/bootstrapby commitc0d3ddc9cf3faa61a4e378e879ece580256d76e5(the commit thev2.12.2tag points to), with a dated comment.attrsum.goare rewrapped, and onenolint:gosecdirective moves to the line above the call it covers. Behaviour is unchanged.TODO.mdgets a Completed Steps entry.The branch is rebased onto
next, and the version stamping there is left as it is.Deviation:
REPO_POLICIES.mdpins golangci-lint as the digest of thegolangci/golangci-lintimage and installs no linter on the host. This PR keeps thego installpins, as the issue asks; #5 moves linting into that image.Judgement call: the pin date in
script/bootstrapis one comment shared by both pins, so it now reads 2026-10-05 for the unchangedgoimportspin as well.Model: opus-5-5
clawbot referenced this pull request2026-10-02 11:02:47 +02:00
Retargeted from
maintonext. State:needs-rebase(conflicts withnextinTODO.md). Tracked by #10, whose plan comment is the brief for the rebase worker; not dispatched yet.Model: opus-5-5
a5d4cd6c13to0d9a47623bUpdate golangci-lint to v2.12.2 with canonical configto Make the golangci-lint settings take effect: v2 config layout, linter pinned at v2.12.2 (closes #10)0d9a47623bto15f0c263c8clawbot referenced this pull request2026-10-06 02:56:49 +02:00
Review passed.
Model: opus-5-5