Adopt scripts-to-rule-them-all scaffold (refs #1) #2

clawbot · 2026-07-26T18:43:57+02:00

clawbot commented

2026-07-26 18:43:57 +02:00

Adds the standard STRTA scaffold to attrsum (issue #1), landing per the owner's option 3 (land the scaffold now; a follow-up branch remediates the pre-existing lint to make it green).

Makefile — nine standard targets as thin @script/NAME shims (hooks -> @script/install-precommit); repo-specific build/clean/try retained.
script/ — POSIX-sh entrypoints (bootstrap, setup, test, lint, fmt, fmt-check, check, docker, install-precommit, cibuild, plus helpers).
.golangci.yml — byte-identical to the org-standard (dnswatcher) config.
Dockerfile — runs make check then make build, so the image fails on any check failure. .gitea/workflows/check.yml runs script/cibuild.

The change is purely additive: attrsum.go / attrsum_test.go are untouched. make fmt-check and make test pass. make check / docker build . are KNOWINGLY RED at the lint step only, on ~192 pre-existing findings in the existing code (independently verified identical on pre-scaffold main) — this is expected and will be resolved by an immediate follow-up lint-remediation PR that makes the gate green and closes #1. This scaffold PR was independently reviewed (verdict PASS) before merge.

Adds the standard STRTA scaffold to attrsum (issue #1), landing per the owner's option 3 (land the scaffold now; a follow-up branch remediates the pre-existing lint to make it green). - `Makefile` — nine standard targets as thin `@script/NAME` shims (`hooks` -> `@script/install-precommit`); repo-specific `build`/`clean`/`try` retained. - `script/` — POSIX-`sh` entrypoints (`bootstrap`, `setup`, `test`, `lint`, `fmt`, `fmt-check`, `check`, `docker`, `install-precommit`, `cibuild`, plus helpers). - `.golangci.yml` — byte-identical to the org-standard (dnswatcher) config. - `Dockerfile` — runs `make check` then `make build`, so the image fails on any check failure. `.gitea/workflows/check.yml` runs `script/cibuild`. The change is purely additive: `attrsum.go` / `attrsum_test.go` are untouched. `make fmt-check` and `make test` pass. `make check` / `docker build .` are KNOWINGLY RED at the lint step only, on ~192 pre-existing findings in the existing code (independently verified identical on pre-scaffold `main`) — this is expected and will be resolved by an immediate follow-up lint-remediation PR that makes the gate green and closes #1. This scaffold PR was independently reviewed (verdict PASS) before merge.

clawbot added 1 commit 2026-07-26 18:43:57 +02:00

Add scripts-to-rule-them-all scaffold (refs #1 )

check / check (push) Failing after 21s

Details

6230bb1c3a

Add the standard STRTA scaffold, mirroring the conformant Go repos:

- script/ POSIX-sh entrypoints (bootstrap, setup, projectname, test,
  lint, fmt, fmt-check, check, docker, cibuild, precommit,
  install-precommit).
- Makefile rewritten as thin shims: .PHONY plus the nine standard
  targets each delegating to script/NAME; repo-specific build, clean,
  and try targets retained.
- .golangci.yml matching the org-standard Go lint config.
- Dockerfile whose build runs make check then make build, so the image
  fails on any check failure.
- .gitea/workflows/check.yml running script/cibuild.

make fmt-check and make test are green. make check is not yet green
because of pre-existing lint findings in the application code, which
are out of scope for this scaffold change; hence refs (not closes).

clawbot merged commit 6230bb1c3a into main

2026-07-26 18:44:01 +02:00

clawbot deleted branch strta-conformance

2026-07-26 18:44:01 +02:00

clawbot referenced this pull request

2026-07-26 19:56:41 +02:00

Remediate all lint findings and make CI green (closes #1) #3

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: sneak/attrsum#2