Clears #approve-tx-password value and hides #approve-tx-error when the transaction approval view is shown, matching the pattern used in showSignApproval and confirmTx.show.
Clears `#approve-tx-password` value and hides `#approve-tx-error` when the transaction approval view is shown, matching the pattern used in `showSignApproval` and `confirmTx.show`.
Closes #85
Clears #approve-tx-password value and hides #approve-tx-error when the
transaction approval view is shown, matching the pattern used in
showSignApproval and confirmTx.show.
Closes#85
Added two lines to showTxApproval() to clear #approve-tx-password value and hide #approve-tx-error, matching the existing pattern in showSignApproval() (line 344-345).
docker build . passes. Ready for review.
Added two lines to `showTxApproval()` to clear `#approve-tx-password` value and hide `#approve-tx-error`, matching the existing pattern in `showSignApproval()` (line 344-345).
`docker build .` passes. Ready for review.
clawbot
self-assigned this 2026-02-28 22:19:30 +01:00
The diff adds two lines to showTxApproval() that clear the password field and hide the error element, exactly matching the pattern in showSignApproval() (lines 344-345). This is the fix described in #85.
Correctness: ✅ uses the same $() helper and .classList.add("hidden") pattern as elsewhere
Edge cases: ✅ clearing an already-empty field or hiding an already-hidden element is harmless
Security: ✅ no sensitive data exposure, password field is properly cleared
**Review: ✅ approved**
The diff adds two lines to `showTxApproval()` that clear the password field and hide the error element, exactly matching the pattern in `showSignApproval()` (lines 344-345). This is the fix described in #85.
- Correctness: ✅ uses the same `$()` helper and `.classList.add("hidden")` pattern as elsewhere
- Edge cases: ✅ clearing an already-empty field or hiding an already-hidden element is harmless
- Security: ✅ no sensitive data exposure, password field is properly cleared
- Build: ✅ `docker build .` passes
Marked `merge-ready`, assigned to @sneak for merge.
sneak
merged commit b826279d8f into main2026-02-28 22:24:55 +01:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Clears
#approve-tx-passwordvalue and hides#approve-tx-errorwhen the transaction approval view is shown, matching the pattern used inshowSignApprovalandconfirmTx.show.Closes #85
Added two lines to
showTxApproval()to clear#approve-tx-passwordvalue and hide#approve-tx-error, matching the existing pattern inshowSignApproval()(line 344-345).docker build .passes. Ready for review.Review: ✅ approved
The diff adds two lines to
showTxApproval()that clear the password field and hide the error element, exactly matching the pattern inshowSignApproval()(lines 344-345). This is the fix described in #85.$()helper and.classList.add("hidden")pattern as elsewheredocker build .passesMarked
merge-ready, assigned to @sneak for merge.