consistency: approve-tx password field not cleared when view is shown #85

New Issue

clawbot · 2026-02-28T21:29:47+01:00

clawbot commented

2026-02-28 21:29:47 +01:00

Problem

In approval.js, the showTxApproval() function does not clear the #approve-tx-password field when the view is shown. By contrast, showSignApproval() does clear #approve-sign-password (line 344), and confirmTx.show() clears #confirm-tx-password.

This means if a user enters a wrong password on a transaction approval, navigates away, and comes back, the old password text may still be present.

Expected behavior

All password fields should be cleared when their view is shown.

Files affected

src/popup/views/approval.js (showTxApproval() function)

Suggested fix

Add $("approve-tx-password").value = ""; and $("approve-tx-error").classList.add("hidden"); to the showTxApproval() function.

Found during consistency audit for #78.

## Problem In `approval.js`, the `showTxApproval()` function does not clear the `#approve-tx-password` field when the view is shown. By contrast, `showSignApproval()` does clear `#approve-sign-password` (line 344), and `confirmTx.show()` clears `#confirm-tx-password`. This means if a user enters a wrong password on a transaction approval, navigates away, and comes back, the old password text may still be present. ## Expected behavior All password fields should be cleared when their view is shown. ## Files affected - `src/popup/views/approval.js` (`showTxApproval()` function) ## Suggested fix Add `$("approve-tx-password").value = "";` and `$("approve-tx-error").classList.add("hidden");` to the `showTxApproval()` function. Found during consistency audit for #78.

clawbot added the

bot

label 2026-02-28 21:29:47 +01:00

clawbot referenced this issue

2026-02-28 21:30:24 +01:00

fix: replace confirm-tx password modal with inline field (closes #78) #83

clawbot referenced this issue

2026-02-28 21:42:51 +01:00

fix: replace confirm-tx password modal with inline field (closes #78) #83

clawbot self-assigned this 2026-02-28 22:09:37 +01:00

clawbot referenced this issue from a commit

2026-02-28 22:10:31 +01:00