SuccessTx and ErrorTx built their links for the active network. Since #621, WaitTx finds a transaction on the network it was sent on even after a network switch and then hands over to these screens, whose links opened an explorer where the transaction does not exist. Both screens now keep the transaction's chain id in their view data and pass it to every link they build: recipient, block and hash, and on SuccessTx the addresses in the decoded action well. The SuccessTx and ErrorTx entries in README say so.
What a reader may trip over:
Because the chain id is in the view data, a popup that reopens onto either screen links to the same network. A stored chain id that names no network would throw while the link is built, so src/popup/viewRouter.js refuses that restore, as it already does for a stored transaction. A missing chain id still falls back to the active network.
Judgement call: that restore check is outside src/popup/views/txStatus.js, the one file the plan named. Without it, a corrupt stored chain id would stop popup start-up.
Model: opus-5-5
Fixes https://git.eeqj.de/sneak/AutistMask/issues/622.
SuccessTx and ErrorTx built their links for the active network. Since https://git.eeqj.de/sneak/AutistMask/pulls/621, WaitTx finds a transaction on the network it was sent on even after a network switch and then hands over to these screens, whose links opened an explorer where the transaction does not exist. Both screens now keep the transaction's chain id in their view data and pass it to every link they build: recipient, block and hash, and on SuccessTx the addresses in the decoded action well. The SuccessTx and ErrorTx entries in README say so.
What a reader may trip over:
- Because the chain id is in the view data, a popup that reopens onto either screen links to the same network. A stored chain id that names no network would throw while the link is built, so `src/popup/viewRouter.js` refuses that restore, as it already does for a stored transaction. A missing chain id still falls back to the active network.
Judgement call: that restore check is outside `src/popup/views/txStatus.js`, the one file the plan named. Without it, a corrupt stored chain id would stop popup start-up.
Model: opus-5-5
SuccessTx and ErrorTx built their recipient, block, hash and decoded-action
address links for the active network. After a network switch, WaitTx now finds
a transaction on the network it was sent on and moves on to these screens, whose
links then opened an explorer where the transaction does not exist. Both
screens now keep the transaction's chain id with their view data and build
every link for that network, as WaitTx does. A stored SuccessTx or ErrorTx
whose chain id names no network is refused on restore, as a stored transaction
already is.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Fixes #622.
SuccessTx and ErrorTx built their links for the active network. Since #621, WaitTx finds a transaction on the network it was sent on even after a network switch and then hands over to these screens, whose links opened an explorer where the transaction does not exist. Both screens now keep the transaction's chain id in their view data and pass it to every link they build: recipient, block and hash, and on SuccessTx the addresses in the decoded action well. The SuccessTx and ErrorTx entries in README say so.
What a reader may trip over:
src/popup/viewRouter.jsrefuses that restore, as it already does for a stored transaction. A missing chain id still falls back to the active network.Judgement call: that restore check is outside
src/popup/views/txStatus.js, the one file the plan named. Without it, a corrupt stored chain id would stop popup start-up.Model: opus-5-5
Review: PASS
Model: opus-5-5