SuccessTx and ErrorTx link to the active network's explorer instead of the transaction's #622

Closed
opened 2026-10-19 23:12:42 +02:00 by clawbot · 2 comments
Collaborator

Seen by the worker on #621.

Where

SuccessTx and ErrorTx, showSuccess() and showError() in src/popup/views/txStatus.js. Their transaction hash and block links are built with explorerUrl() for the active network.

What happens

The popup reopens onto WaitTx for a Sepolia transaction after the user switched to Ethereum Mainnet. Once #621 lands, WaitTx finds the receipt on Sepolia and moves on to SuccessTx (or ErrorTx), whose hash and block links open the mainnet explorer, where the transaction does not exist.

What should happen

As for WaitTx and TransactionDetail: a transaction screen describes the transaction on the network it was sent on, so its links go to that network's explorer, whichever network is active.

Severity: minor

Definition of done

  • SuccessTx and ErrorTx link the transaction and its block to the explorer of the network the transaction was sent on.
  • A test of each with the other network active.

Model: opus-5-5

Seen by the worker on https://git.eeqj.de/sneak/AutistMask/pulls/621. ## Where SuccessTx and ErrorTx, `showSuccess()` and `showError()` in `src/popup/views/txStatus.js`. Their transaction hash and block links are built with `explorerUrl()` for the active network. ## What happens The popup reopens onto WaitTx for a Sepolia transaction after the user switched to Ethereum Mainnet. Once https://git.eeqj.de/sneak/AutistMask/pulls/621 lands, WaitTx finds the receipt on Sepolia and moves on to SuccessTx (or ErrorTx), whose hash and block links open the mainnet explorer, where the transaction does not exist. ## What should happen As for WaitTx and TransactionDetail: a transaction screen describes the transaction on the network it was sent on, so its links go to that network's explorer, whichever network is active. Severity: minor ## Definition of done - [ ] SuccessTx and ErrorTx link the transaction and its block to the explorer of the network the transaction was sent on. - [ ] A test of each with the other network active. Model: opus-5-5
clawbot self-assigned this 2026-10-19 23:12:42 +02:00
Author
Collaborator

Plan: one PR to next. In src/popup/views/txStatus.js, SuccessTx and ErrorTx pass the transaction's chain id to the hash and block link helpers, as WaitTx now does, so explorerUrl() builds every link on both screens for the network the transaction was sent on. Jest tests of each screen with the other network active, failing on next.

Model: opus-5-5

Plan: one PR to `next`. In `src/popup/views/txStatus.js`, SuccessTx and ErrorTx pass the transaction's chain id to the hash and block link helpers, as WaitTx now does, so `explorerUrl()` builds every link on both screens for the network the transaction was sent on. Jest tests of each screen with the other network active, failing on `next`. Model: opus-5-5
Author
Collaborator

Built in #624. SuccessTx and ErrorTx keep the transaction's chain id in their view data, so every link they build, the decoded action's addresses on SuccessTx included, opens that network's explorer, also when the popup reopens onto them. A stored chain id that names no network is refused on restore.

Model: opus-5-5

Built in https://git.eeqj.de/sneak/AutistMask/pulls/624. SuccessTx and ErrorTx keep the transaction's chain id in their view data, so every link they build, the decoded action's addresses on SuccessTx included, opens that network's explorer, also when the popup reopens onto them. A stored chain id that names no network is refused on restore. Model: opus-5-5
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/AutistMask#622