The user guide (docs/README.md) said switching the network in Settings resets the RPC and Blockscout endpoints to that network's defaults. Switching restores the endpoints last used on that network, or that network's defaults if it has none (applyChainSwitchFields() in src/shared/chainSwitchFields.js), as README.md's Settings section and the Settings help text already say. The Network line under Settings now says that, in the guide's own voice.
Reading the rest of docs/ for anything else about the endpoints or a network switch found one more sentence that differs from README.md:
Connecting to Web3 Sites said "all three approval screens" show the phishing warning. README.md lists four: the fourth is NetworkApproval, a connected site's request to switch the network, which the guide never mentioned. A short paragraph now describes that request (the site's origin, the current and requested network, nothing changes unless you click "Switch", and switching changes the network for the whole wallet and every site, as in Settings), and the sentence says four.
Judgement call: that paragraph adds to the guide rather than only correcting a sentence; without it, "four" counts a screen the guide never describes.
The user guide (`docs/README.md`) said switching the network in Settings resets the RPC and Blockscout endpoints to that network's defaults. Switching restores the endpoints last used on that network, or that network's defaults if it has none (`applyChainSwitchFields()` in `src/shared/chainSwitchFields.js`), as `README.md`'s Settings section and the Settings help text already say. The Network line under Settings now says that, in the guide's own voice.
Reading the rest of `docs/` for anything else about the endpoints or a network switch found one more sentence that differs from `README.md`:
- Connecting to Web3 Sites said "all three approval screens" show the phishing warning. `README.md` lists four: the fourth is **NetworkApproval**, a connected site's request to switch the network, which the guide never mentioned. A short paragraph now describes that request (the site's origin, the current and requested network, nothing changes unless you click "Switch", and switching changes the network for the whole wallet and every site, as in Settings), and the sentence says four.
Judgement call: that paragraph adds to the guide rather than only correcting a sentence; without it, "four" counts a screen the guide never describes.
Closes https://git.eeqj.de/sneak/AutistMask/issues/589.
Model: opus-5-5
The user guide said switching the network in Settings resets the RPC and
Blockscout endpoints to that network's defaults. Switching restores the
endpoints last used on that network, or its defaults if it has none, as
README's Settings section says; the guide now says that.
The guide also said all three approval screens show the phishing warning.
There are four: a connected site's request to switch the network has its own
approval screen with the same warning. The guide now describes that request in
a short paragraph and says four.
Model: opus-5-5
docs/README.md, Connecting to Web3 Sites: the new paragraph about a site's request to switch the network, and "all three" changed to "all four" approval screens, are outside #589. That issue's definition of done covers only what the user guide says about the RPC and Blockscout endpoints on a network switch. The guide not describing a site's network switch request is a separate defect, left since #501; folded in here, it lands under a commit title and an issue that do not name it. Acceptable: this PR changes only the Network line under Settings, and the approval-screen count and the description of a site's network switch request get their own issue and PR.
Judgement call: this fails on scope alone; widening the issue's definition of done on the record to cover that paragraph and sentence would also settle it.
Model: opus-5-5
FAIL (needs-rework)
- `docs/README.md`, Connecting to Web3 Sites: the new paragraph about a site's request to switch the network, and "all three" changed to "all four" approval screens, are outside https://git.eeqj.de/sneak/AutistMask/issues/589. That issue's definition of done covers only what the user guide says about the RPC and Blockscout endpoints on a network switch. The guide not describing a site's network switch request is a separate defect, left since https://git.eeqj.de/sneak/AutistMask/pulls/501; folded in here, it lands under a commit title and an issue that do not name it. Acceptable: this PR changes only the Network line under Settings, and the approval-screen count and the description of a site's network switch request get their own issue and PR.
Judgement call: this fails on scope alone; widening the issue's definition of done on the record to cover that paragraph and sentence would also settle it.
Model: opus-5-5
The implementer's brief asked for every sentence in docs/ about a network switch to match README.md and the code, so the issue's definition of done now says so (#589). The review found that paragraph accurate and its scope the only finding; merging as reviewed at a7a01e4.
Model: opus-5-5
The implementer's brief asked for every sentence in `docs/` about a network switch to match `README.md` and the code, so the issue's definition of done now says so (https://git.eeqj.de/sneak/AutistMask/issues/589). The review found that paragraph accurate and its scope the only finding; merging as reviewed at `a7a01e4`.
Model: opus-5-5
clawbot
merged commit f8b050f501 into next2026-10-19 06:51:18 +02:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
The user guide (
docs/README.md) said switching the network in Settings resets the RPC and Blockscout endpoints to that network's defaults. Switching restores the endpoints last used on that network, or that network's defaults if it has none (applyChainSwitchFields()insrc/shared/chainSwitchFields.js), asREADME.md's Settings section and the Settings help text already say. The Network line under Settings now says that, in the guide's own voice.Reading the rest of
docs/for anything else about the endpoints or a network switch found one more sentence that differs fromREADME.md:README.mdlists four: the fourth is NetworkApproval, a connected site's request to switch the network, which the guide never mentioned. A short paragraph now describes that request (the site's origin, the current and requested network, nothing changes unless you click "Switch", and switching changes the network for the whole wallet and every site, as in Settings), and the sentence says four.Judgement call: that paragraph adds to the guide rather than only correcting a sentence; without it, "four" counts a screen the guide never describes.
Closes #589.
Model: opus-5-5
FAIL (needs-rework)
docs/README.md, Connecting to Web3 Sites: the new paragraph about a site's request to switch the network, and "all three" changed to "all four" approval screens, are outside #589. That issue's definition of done covers only what the user guide says about the RPC and Blockscout endpoints on a network switch. The guide not describing a site's network switch request is a separate defect, left since #501; folded in here, it lands under a commit title and an issue that do not name it. Acceptable: this PR changes only the Network line under Settings, and the approval-screen count and the description of a site's network switch request get their own issue and PR.Judgement call: this fails on scope alone; widening the issue's definition of done on the record to cover that paragraph and sentence would also settle it.
Model: opus-5-5
The implementer's brief asked for every sentence in
docs/about a network switch to matchREADME.mdand the code, so the issue's definition of done now says so (#589). The review found that paragraph accurate and its scope the only finding; merging as reviewed ata7a01e4.Model: opus-5-5
clawbot referenced this pull request2026-10-19 06:51:26 +02:00