ConfirmTx warned when the node's transaction count for the recipient was zero. That count is the number of transactions the address has sent, so an address that only receives (a savings address, an exchange deposit address) got the "ZERO transaction history" box on every send to it.
getFullWarnings() in src/shared/addressWarnings.js now also asks the same node for the recipient's balance when the count is zero, and warns only when both are zero. ETH an address received stays in its balance until it sends a transaction, so a balance shows it has received. The box now says the address has never sent a transaction and holds no ETH.
The sentence moved from src/popup/index.html into show() in src/popup/views/confirmTx.js, because it names the active network's native token, as the contract warning next to it already did. The README ConfirmTx entry and its native-token paragraph follow the new wording.
The check's failure log line is now "tx count or balance check failed"; tests/rpcErrorLog.test.js looks for that text.
New file: tests/addressWarnings.test.js, in tests/.
Judgement call: the plan says "holds no ETH"; the box uses the network's own label (SepoliaETH on Sepolia), per the README rule on native-token labels.
Not changed: an address that has received only tokens and no ETH still gets the warning, whose wording is accurate for it.
Model: opus-5-5
Fixes https://git.eeqj.de/sneak/AutistMask/issues/528.
ConfirmTx warned when the node's transaction count for the recipient was zero. That count is the number of transactions the address has sent, so an address that only receives (a savings address, an exchange deposit address) got the "ZERO transaction history" box on every send to it.
`getFullWarnings()` in `src/shared/addressWarnings.js` now also asks the same node for the recipient's balance when the count is zero, and warns only when both are zero. ETH an address received stays in its balance until it sends a transaction, so a balance shows it has received. The box now says the address has never sent a transaction and holds no ETH.
The sentence moved from `src/popup/index.html` into `show()` in `src/popup/views/confirmTx.js`, because it names the active network's native token, as the contract warning next to it already did. The README ConfirmTx entry and its native-token paragraph follow the new wording.
The check's failure log line is now "tx count or balance check failed"; `tests/rpcErrorLog.test.js` looks for that text.
New file: `tests/addressWarnings.test.js`, in `tests/`.
Judgement call: the plan says "holds no ETH"; the box uses the network's own label (`SepoliaETH` on Sepolia), per the README rule on native-token labels.
Not changed: an address that has received only tokens and no ETH still gets the warning, whose wording is accurate for it.
Model: opus-5-5
The transaction count the node reports is what an address has sent, so
an address that only receives, such as a savings address, got the "ZERO
transaction history" box on every send. The check now also asks the node
for the recipient's balance and warns only when both are zero. The box
says the address has never sent a transaction and holds no ETH, naming
the active network's native token as the contract warning does.
Model: opus-5-5
clawbot
self-assigned this 2026-10-19 01:05:52 +02:00
PASS: this change meets the definition of done and the plan on #528 and is ready to merge into next.
Not verified: the confirmation screen in a real browser.
Model: opus-5-5
PASS: this change meets the definition of done and the plan on https://git.eeqj.de/sneak/AutistMask/issues/528 and is ready to merge into `next`.
Not verified: the confirmation screen in a real browser.
Model: opus-5-5
clawbot
merged commit e2e1c5d40e into next2026-10-19 02:34:15 +02:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Fixes #528.
ConfirmTx warned when the node's transaction count for the recipient was zero. That count is the number of transactions the address has sent, so an address that only receives (a savings address, an exchange deposit address) got the "ZERO transaction history" box on every send to it.
getFullWarnings()insrc/shared/addressWarnings.jsnow also asks the same node for the recipient's balance when the count is zero, and warns only when both are zero. ETH an address received stays in its balance until it sends a transaction, so a balance shows it has received. The box now says the address has never sent a transaction and holds no ETH.The sentence moved from
src/popup/index.htmlintoshow()insrc/popup/views/confirmTx.js, because it names the active network's native token, as the contract warning next to it already did. The README ConfirmTx entry and its native-token paragraph follow the new wording.The check's failure log line is now "tx count or balance check failed";
tests/rpcErrorLog.test.jslooks for that text.New file:
tests/addressWarnings.test.js, intests/.Judgement call: the plan says "holds no ETH"; the box uses the network's own label (
SepoliaETHon Sepolia), per the README rule on native-token labels.Not changed: an address that has received only tokens and no ETH still gets the warning, whose wording is accurate for it.
Model: opus-5-5
PASS: this change meets the definition of done and the plan on #528 and is ready to merge into
next.Not verified: the confirmation screen in a real browser.
Model: opus-5-5