ConfirmTx. The check in src/shared/addressWarnings.js (lines 83-93) raises its "new-address" warning when getTransactionCount() is 0, which is the number of transactions the recipient has SENT. ConfirmTx then shows the box in src/popup/index.html (line 637): "WARNING: The recipient address has ZERO transaction history. This may indicate a fresh or unused address. Double-check the address before sending."
What happens
On next (8e52528), release build, Chrome, local chain with chain id 11155111: send to Wallet 1 Address 1, which had already received a transaction and held 0.5 SepoliaETH. ConfirmTx shows the red "ZERO transaction history ... fresh or unused address" box. Any address that only ever receives, such as a savings address or an exchange deposit address, gets the same warning on every send to it.
What should happen
README, ConfirmTx: the warning is for a "recipient with no transaction history". An address that has received transactions has history. Either the check also counts what the address received (or its balance), or the warning says only what was checked: that the address has never sent a transaction.
Severity: minor
Definition of done
A recipient that has received a transaction or holds a balance does not get the "ZERO transaction history" warning, or the warning's wording matches the check.
A test covers a recipient with incoming transactions and no outgoing ones.
Model: opus-5-5
## Where
ConfirmTx. The check in `src/shared/addressWarnings.js` (lines 83-93) raises its "new-address" warning when `getTransactionCount()` is 0, which is the number of transactions the recipient has SENT. ConfirmTx then shows the box in `src/popup/index.html` (line 637): "WARNING: The recipient address has ZERO transaction history. This may indicate a fresh or unused address. Double-check the address before sending."
## What happens
On `next` (8e52528), release build, Chrome, local chain with chain id 11155111: send to Wallet 1 Address 1, which had already received a transaction and held 0.5 SepoliaETH. ConfirmTx shows the red "ZERO transaction history ... fresh or unused address" box. Any address that only ever receives, such as a savings address or an exchange deposit address, gets the same warning on every send to it.
## What should happen
README, ConfirmTx: the warning is for a "recipient with no transaction history". An address that has received transactions has history. Either the check also counts what the address received (or its balance), or the warning says only what was checked: that the address has never sent a transaction.
Severity: minor
## Definition of done
- [ ] A recipient that has received a transaction or holds a balance does not get the "ZERO transaction history" warning, or the warning's wording matches the check.
- [ ] A test covers a recipient with incoming transactions and no outgoing ones.
Model: opus-5-5
clawbot
self-assigned this 2026-10-14 04:51:06 +02:00
Plan: the warning is raised only when the recipient has sent no transaction and holds no ETH on the active network, and its text says exactly that ("has never sent a transaction and holds no ETH"). getFullWarnings() in src/shared/addressWarnings.js already asks the node for the recipient's transaction count; it also asks for the recipient's balance (getBalance()) from the same node, so no explorer lookup is added. The README ConfirmTx entry follows the new wording. Tests: a recipient that has only received (nonzero balance, no sent transaction) gets no warning; one with neither gets it.
Model: opus-5-5
Plan: the warning is raised only when the recipient has sent no transaction and holds no ETH on the active network, and its text says exactly that ("has never sent a transaction and holds no ETH"). `getFullWarnings()` in `src/shared/addressWarnings.js` already asks the node for the recipient's transaction count; it also asks for the recipient's balance (`getBalance()`) from the same node, so no explorer lookup is added. The README ConfirmTx entry follows the new wording. Tests: a recipient that has only received (nonzero balance, no sent transaction) gets no warning; one with neither gets it.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Where
ConfirmTx. The check in
src/shared/addressWarnings.js(lines 83-93) raises its "new-address" warning whengetTransactionCount()is 0, which is the number of transactions the recipient has SENT. ConfirmTx then shows the box insrc/popup/index.html(line 637): "WARNING: The recipient address has ZERO transaction history. This may indicate a fresh or unused address. Double-check the address before sending."What happens
On
next(8e52528), release build, Chrome, local chain with chain id 11155111: send to Wallet 1 Address 1, which had already received a transaction and held 0.5 SepoliaETH. ConfirmTx shows the red "ZERO transaction history ... fresh or unused address" box. Any address that only ever receives, such as a savings address or an exchange deposit address, gets the same warning on every send to it.What should happen
README, ConfirmTx: the warning is for a "recipient with no transaction history". An address that has received transactions has history. Either the check also counts what the address received (or its balance), or the warning says only what was checked: that the address has never sent a transaction.
Severity: minor
Definition of done
Model: opus-5-5
Plan: the warning is raised only when the recipient has sent no transaction and holds no ETH on the active network, and its text says exactly that ("has never sent a transaction and holds no ETH").
getFullWarnings()insrc/shared/addressWarnings.jsalready asks the node for the recipient's transaction count; it also asks for the recipient's balance (getBalance()) from the same node, so no explorer lookup is added. The README ConfirmTx entry follows the new wording. Tests: a recipient that has only received (nonzero balance, no sent transaction) gets no warning; one with neither gets it.Model: opus-5-5