The address on the connection prompt now sits on its own row under the title line, so all 42 characters show at the popup's width.
renderAddressHtml() returns the colour dot and title as one block and the address as the next, meant to stack. The element they go into on this prompt, #approve-address, was a flex row, which put the two blocks side by side and left the address 236px for about 300px of text. The address row scrolls sideways rather than clipping, so its tail was out of view but still in the text, which is why the existing test that reads the text did not notice. The element now has the same classes as the one on the signature screen.
The Chrome browser suite's connection test now also calls assertAddressesFit(), the measurement the other screens already get: the whole address on one line, with nothing of it outside its row.
Judgement call: only the Chrome suite measures the row. The Firefox suite still checks the text alone; the fix is the same markup in both browsers.
Model: opus-5-5
Closes https://git.eeqj.de/sneak/AutistMask/issues/517
The address on the connection prompt now sits on its own row under the title line, so all 42 characters show at the popup's width.
`renderAddressHtml()` returns the colour dot and title as one block and the address as the next, meant to stack. The element they go into on this prompt, `#approve-address`, was a flex row, which put the two blocks side by side and left the address 236px for about 300px of text. The address row scrolls sideways rather than clipping, so its tail was out of view but still in the text, which is why the existing test that reads the text did not notice. The element now has the same classes as the one on the signature screen.
The Chrome browser suite's connection test now also calls `assertAddressesFit()`, the measurement the other screens already get: the whole address on one line, with nothing of it outside its row.
Judgement call: only the Chrome suite measures the row. The Firefox suite still checks the text alone; the fix is the same markup in both browsers.
Model: opus-5-5
The element holding the address on the connection prompt was a flex row,
so the title line and the address that renderAddressHtml() returns sat
side by side and the address got only the width left over, which hid its
last nine characters. It is now a plain block, as on the signature
screen, so the address has a row of its own. The Chrome browser suite's
connection test now measures that row with the check the other screens
already use.
Model: opus-5-5
PASS: the connection prompt now shows the shared address whole on a row of its own in Chrome and Firefox, at the popup's width and in the approval window, and the connection test now fails if any of the address is hidden.
Disclosure: checked against next at 00d1fec; the two commits merged since (cb27281, f283a5b) change none of the files this PR touches, and it rebases onto them cleanly.
Model: opus-5-5
PASS: the connection prompt now shows the shared address whole on a row of its own in Chrome and Firefox, at the popup's width and in the approval window, and the connection test now fails if any of the address is hidden.
Disclosure: checked against `next` at `00d1fec`; the two commits merged since (`cb27281`, `f283a5b`) change none of the files this PR touches, and it rebases onto them cleanly.
Model: opus-5-5
clawbot
merged commit 8e20a4e21c into next2026-10-14 17:11:35 +02:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Closes #517
The address on the connection prompt now sits on its own row under the title line, so all 42 characters show at the popup's width.
renderAddressHtml()returns the colour dot and title as one block and the address as the next, meant to stack. The element they go into on this prompt,#approve-address, was a flex row, which put the two blocks side by side and left the address 236px for about 300px of text. The address row scrolls sideways rather than clipping, so its tail was out of view but still in the text, which is why the existing test that reads the text did not notice. The element now has the same classes as the one on the signature screen.The Chrome browser suite's connection test now also calls
assertAddressesFit(), the measurement the other screens already get: the whole address on one line, with nothing of it outside its row.Judgement call: only the Chrome suite measures the row. The Firefox suite still checks the text alone; the fix is the same markup in both browsers.
Model: opus-5-5
PASS: the connection prompt now shows the shared address whole on a row of its own in Chrome and Firefox, at the popup's width and in the approval window, and the connection test now fails if any of the address is hidden.
Disclosure: checked against
nextat00d1fec; the two commits merged since (cb27281,f283a5b) change none of the files this PR touches, and it rebases onto them cleanly.Model: opus-5-5