The connection prompt hides the last characters of the address it will share #517

Open
opened 2026-10-14 04:43:39 +02:00 by clawbot · 2 comments
Collaborator

Where

SiteApproval (Connection Request). The container #approve-address in src/popup/index.html (lines 1715-1718) carries flex items-center, so the two rows renderAddressHtml() builds (the title line, then the address) are laid out side by side instead of one under the other.

What happens

On next (8e52528), release build, Chrome: a site asks to connect. Under "Address that will be shared:" the screen shows the colour dot and "Wallet 2 — Address 1" wrapped onto two lines, with the address squeezed beside them into 236px. The address box needs 302px, so it shows 0x3B8A794B8b6d3Fb1478A642A7Ca7054 and the last nine characters are hidden. This happens at the popup's full 396px width, not only in a narrow window.

What should happen

README, Visual Style: "every address in the popup is rendered on a row of its own, wide enough for all 42 characters, and no screen truncates one to fit". README, SiteApproval: the screen shows the full address that will be shared. It should be laid out as on the signature screen: the title line, then the whole address on its own row.

Severity: major

Definition of done

  • The connection prompt shows the shared address on a row of its own, all 42 characters visible at the popup's width.
  • A browser test reads the address element on the connection prompt and checks that nothing of it is hidden.

Model: opus-5-5

## Where SiteApproval (Connection Request). The container `#approve-address` in `src/popup/index.html` (lines 1715-1718) carries `flex items-center`, so the two rows `renderAddressHtml()` builds (the title line, then the address) are laid out side by side instead of one under the other. ## What happens On `next` (8e52528), release build, Chrome: a site asks to connect. Under "Address that will be shared:" the screen shows the colour dot and "Wallet 2 — Address 1" wrapped onto two lines, with the address squeezed beside them into 236px. The address box needs 302px, so it shows `0x3B8A794B8b6d3Fb1478A642A7Ca7054` and the last nine characters are hidden. This happens at the popup's full 396px width, not only in a narrow window. ## What should happen README, Visual Style: "every address in the popup is rendered on a row of its own, wide enough for all 42 characters, and no screen truncates one to fit". README, SiteApproval: the screen shows the full address that will be shared. It should be laid out as on the signature screen: the title line, then the whole address on its own row. Severity: major ## Definition of done - [ ] The connection prompt shows the shared address on a row of its own, all 42 characters visible at the popup's width. - [ ] A browser test reads the address element on the connection prompt and checks that nothing of it is hidden. Model: opus-5-5
clawbot self-assigned this 2026-10-14 04:43:39 +02:00
Author
Collaborator

Same on Firefox 153 (release build, approval window): the address box is 236 pixels wide for a 304-pixel address.

Model: opus-5-5

Same on Firefox 153 (release build, approval window): the address box is 236 pixels wide for a 304-pixel address. Model: opus-5-5
Author
Collaborator

Fixed in #548: the element holding the address on the connection prompt is no longer a flex row, so the address sits on its own row under the title line, as on the signature screen. The Chrome browser suite's connection test now measures that the whole address is visible.

Model: opus-5-5

Fixed in https://git.eeqj.de/sneak/AutistMask/pulls/548: the element holding the address on the connection prompt is no longer a flex row, so the address sits on its own row under the title line, as on the signature screen. The Chrome browser suite's connection test now measures that the whole address is visible. Model: opus-5-5
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/AutistMask#517