Removes the one entry in ALLOWED_ERRORS in tests/e2e/firefox/run.js, Firefox reporting a popup promise that settled after the page unloaded, together with allowedFor() and the code that set tolerated errors aside and printed them. Every uncaught error from an extension source now fails the step it is drained after, or the run when it arrives after the last step, with no exception.
The entry's cause, the site-connection buttons sending their decision with an unawaited sendMessage before closing, went with #275 (in #289). Kept, the entry would also have hidden the same error from any other popup code that sends and then closes, such as the sign and transaction Reject buttons.
The README.md paragraph that described the tolerated error is removed. The paragraph above it already says any uncaught moz-extension:// error fails the run, which is now true without exception.
Judgement call: the list and its handling go entirely rather than staying as an empty list. The Chrome harness, tests/e2e/harness.js, keeps its own empty ALLOWED_ERRORS and is not touched here.
Removes the one entry in `ALLOWED_ERRORS` in `tests/e2e/firefox/run.js`, Firefox reporting a popup promise that settled after the page unloaded, together with `allowedFor()` and the code that set tolerated errors aside and printed them. Every uncaught error from an extension source now fails the step it is drained after, or the run when it arrives after the last step, with no exception.
The entry's cause, the site-connection buttons sending their decision with an unawaited `sendMessage` before closing, went with https://git.eeqj.de/sneak/AutistMask/issues/275 (in https://git.eeqj.de/sneak/AutistMask/pulls/289). Kept, the entry would also have hidden the same error from any other popup code that sends and then closes, such as the sign and transaction Reject buttons.
The `README.md` paragraph that described the tolerated error is removed. The paragraph above it already says any uncaught `moz-extension://` error fails the run, which is now true without exception.
Judgement call: the list and its handling go entirely rather than staying as an empty list. The Chrome harness, `tests/e2e/harness.js`, keeps its own empty `ALLOWED_ERRORS` and is not touched here.
Closes https://git.eeqj.de/sneak/AutistMask/issues/487
Model: opus-5-5
The one entry in ALLOWED_ERRORS in tests/e2e/firefox/run.js, Firefox
reporting a popup promise that settled after the page unloaded, lost its
cause when the site-connection buttons stopped sending with an unawaited
sendMessage before closing (#275). Left in place it would also hide the
same error from any other popup code that sends and then closes. The
entry goes, with the code that only printed and set aside tolerated
errors, and the README paragraph that described it.
Model: opus-5-5
Rebased onto eeb10c2; TODO.md conflicted under Completed Steps and keeps both entries, the one for #487 above the one for #378; nothing else changed.
Model: opus-5-5
Rebased onto `eeb10c2`; `TODO.md` conflicted under Completed Steps and keeps both entries, the one for https://git.eeqj.de/sneak/AutistMask/issues/487 above the one for https://git.eeqj.de/sneak/AutistMask/issues/378; nothing else changed.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Removes the one entry in
ALLOWED_ERRORSintests/e2e/firefox/run.js, Firefox reporting a popup promise that settled after the page unloaded, together withallowedFor()and the code that set tolerated errors aside and printed them. Every uncaught error from an extension source now fails the step it is drained after, or the run when it arrives after the last step, with no exception.The entry's cause, the site-connection buttons sending their decision with an unawaited
sendMessagebefore closing, went with #275 (in #289). Kept, the entry would also have hidden the same error from any other popup code that sends and then closes, such as the sign and transaction Reject buttons.The
README.mdparagraph that described the tolerated error is removed. The paragraph above it already says any uncaughtmoz-extension://error fails the run, which is now true without exception.Judgement call: the list and its handling go entirely rather than staying as an empty list. The Chrome harness,
tests/e2e/harness.js, keeps its own emptyALLOWED_ERRORSand is not touched here.Closes #487
Model: opus-5-5
PASS
Model: opus-5-5
3eddb12569to2704ecc834clawbot referenced this pull request2026-10-07 06:48:41 +02:00
Rebased onto
eeb10c2;TODO.mdconflicted under Completed Steps and keeps both entries, the one for #487 above the one for #378; nothing else changed.Model: opus-5-5
PASS
Model: opus-5-5