sneak/AutistMask
1
0
Fork 0
Code Issues 23 Pull Requests 3 Actions 62 Packages Projects Releases Wiki Activity

test: the Firefox suite still tolerates an error whose cause was removed #487

New Issue
Open
opened 2026-10-07 04:33:27 +02:00 by clawbot · 2 comments
clawbot commented 2026-10-07 04:33:27 +02:00
Collaborator
Copy Link
Copy Source

ALLOWED_ERRORS in tests/e2e/firefox/run.js still tolerates "Promise resolved/rejected after context unloaded" from anywhere in src/popup/index.js, and names #275 as the issue that removes it. That issue is closed and the entry is still there.

Its cause is gone: the site-connection buttons used to send their decision with an unawaited sendMessage and then close, and since #289 they post it on the approval port instead. The Firefox CI job printed the tolerated error before that change and has not printed it in the runs checked since. Left in place, the entry would also hide the same error from any other popup code that sends without waiting and then closes, such as the sign and transaction Reject buttons.

Found while updating the README's end-to-end limits in #293, which describes the entry as it stands.

Definition of done

  • The entry is gone from ALLOWED_ERRORS in tests/e2e/firefox/run.js, along with the code that only existed to print tolerated errors, if nothing else is left on the list.
  • The README.md paragraph in the Firefox section that describes the tolerated error is removed or corrected to match.
  • make test-e2e-firefox passes.
  • TODO.md updated in the same commit.

Model: opus-5-5

`ALLOWED_ERRORS` in `tests/e2e/firefox/run.js` still tolerates "Promise resolved/rejected after context unloaded" from anywhere in `src/popup/index.js`, and names https://git.eeqj.de/sneak/AutistMask/issues/275 as the issue that removes it. That issue is closed and the entry is still there. Its cause is gone: the site-connection buttons used to send their decision with an unawaited `sendMessage` and then close, and since https://git.eeqj.de/sneak/AutistMask/pulls/289 they post it on the approval port instead. The Firefox CI job printed the tolerated error before that change and has not printed it in the runs checked since. Left in place, the entry would also hide the same error from any other popup code that sends without waiting and then closes, such as the sign and transaction Reject buttons. Found while updating the README's end-to-end limits in https://git.eeqj.de/sneak/AutistMask/issues/293, which describes the entry as it stands. ## Definition of done - [ ] The entry is gone from `ALLOWED_ERRORS` in `tests/e2e/firefox/run.js`, along with the code that only existed to print tolerated errors, if nothing else is left on the list. - [ ] The `README.md` paragraph in the Firefox section that describes the tolerated error is removed or corrected to match. - [ ] `make test-e2e-firefox` passes. - [ ] `TODO.md` updated in the same commit. Model: opus-5-5
clawbot commented 2026-10-07 05:59:43 +02:00
Author
Collaborator
Copy Link
Copy Source

Plan: remove the tolerated error from the Firefox suite's ALLOWED_ERRORS, and the code that only served it if the list is then empty; correct the README paragraph. One make test-e2e-firefox run; if the error still appears, its source is reported here instead of a PR.

Model: opus-5-5

Plan: remove the tolerated error from the Firefox suite's `ALLOWED_ERRORS`, and the code that only served it if the list is then empty; correct the README paragraph. One `make test-e2e-firefox` run; if the error still appears, its source is reported here instead of a PR. Model: opus-5-5
clawbot commented 2026-10-07 06:23:28 +02:00
Author
Collaborator
Copy Link
Copy Source

#490 removes the entry, the code that printed tolerated errors, and the README paragraph that described it.

Model: opus-5-5

https://git.eeqj.de/sneak/AutistMask/pulls/490 removes the entry, the code that printed tolerated errors, and the README paragraph that described it. Model: opus-5-5
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
critical
Extremely important: data loss, a security hole, production down, or basic use impossible
 merge-ready
needs-checks
needs-rebase
needs-review
needs-rework
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
clawbot sneak (Jeffrey Paul)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/AutistMask#487