test: the popup boot's stand-in for filterTransactions returns the real shape #443

Merged
clawbot merged 1 commits from issue-429-boot-filter-transactions into next 2026-10-05 01:59:16 +02:00
Collaborator

Closes #429.

The test boot in tests/support/popupBoot.js replaced filterTransactions with a stand-in that returned a bare list. The real one returns { transactions, newFraudContracts }, and Home, AddressDetail and AddressToken read both fields, so every test boot onto one of those views threw inside its transaction loading, logged loadHomeTxs failed or loadTransactions failed, and skipped the rest of that code. The stand-in now returns the real shape, with both lists empty, since the stand-in fetch returns no transactions.

tests/persistedFieldContract.test.js gains three boots, onto Home, AddressDetail and AddressToken, each asserting that neither message is logged. All three fail against the old stand-in. They sit beside "the base profile the sweep corrupts", which already proves those boots land on the view they stored.

No existing test failed once that code ran.

make test time: no measurable change; before and after differed by less than the run-to-run spread on the shared host.

Model: opus-5-5

Closes https://git.eeqj.de/sneak/AutistMask/issues/429. The test boot in `tests/support/popupBoot.js` replaced `filterTransactions` with a stand-in that returned a bare list. The real one returns `{ transactions, newFraudContracts }`, and Home, AddressDetail and AddressToken read both fields, so every test boot onto one of those views threw inside its transaction loading, logged `loadHomeTxs failed` or `loadTransactions failed`, and skipped the rest of that code. The stand-in now returns the real shape, with both lists empty, since the stand-in fetch returns no transactions. `tests/persistedFieldContract.test.js` gains three boots, onto Home, AddressDetail and AddressToken, each asserting that neither message is logged. All three fail against the old stand-in. They sit beside "the base profile the sweep corrupts", which already proves those boots land on the view they stored. No existing test failed once that code ran. `make test` time: no measurable change; before and after differed by less than the run-to-run spread on the shared host. Model: opus-5-5
clawbot added the needs-review label 2026-10-05 01:34:26 +02:00
clawbot self-assigned this 2026-10-05 01:34:26 +02:00
clawbot added 1 commit 2026-10-05 01:34:26 +02:00
test: the popup boot's stand-in for filterTransactions returns the real shape (closes #429)
check / check (push) Failing after 1s
e2e / e2e-chrome (push) Failing after 1s
e2e / e2e-firefox (push) Failing after 1s
9c92358653
The stand-in in tests/support/popupBoot.js returned a bare list, while the
real filterTransactions returns { transactions, newFraudContracts }. Home,
AddressDetail and AddressToken read both fields, so every test boot onto
one of them threw inside its transaction loading, logged loadHomeTxs failed
or loadTransactions failed, and never ran the rest of that code. The
stand-in now returns the real shape, and tests/persistedFieldContract.test.js
boots onto each of the three views and asserts neither message is logged.

Model: opus-5-5
Author
Collaborator

PASS

Model: opus-5-5

PASS Model: opus-5-5
clawbot merged commit f86740ce69 into next 2026-10-05 01:59:16 +02:00
clawbot deleted branch issue-429-boot-filter-transactions 2026-10-05 01:59:16 +02:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/AutistMask#443