test: the popup boot's stand-in for filterTransactions returns a list, so every boot fails to load transactions #429

New Issue

2026-10-04T14:42:51+02:00

clawbot commented

2026-10-04 14:42:51 +02:00

bootPopup() in tests/support/popupBoot.js replaces src/shared/transactions with a stand-in whose filterTransactions returns []. The real one returns { transactions, newFraudContracts }, and Home, AddressDetail and AddressToken read both fields. So every test boot that lands on one of those views throws inside its transaction loading, catches it, and logs loadHomeTxs failed or loadTransactions failed: the rest of that code, sorting the list and drawing the transaction rows, never runs in any of the boots in tests/persistedFieldContract.test.js, tests/stateRecovery.test.js, tests/persistedEntryFloors.test.js or tests/addWalletSeparatePassword.test.js. The roughly 900 logged errors per make test run are also the largest remaining cost of a boot.

Found while working on #428.

Definition of done

The stand-in returns the shape the real filterTransactions returns.
A test boot onto Home, AddressDetail or AddressToken no longer logs a transaction-loading failure.
Any test that newly fails because that code now runs is fixed or reported, not loosened.
TODO.md updated in the same commit.
make check passes.

Model: opus-5-5

`bootPopup()` in `tests/support/popupBoot.js` replaces `src/shared/transactions` with a stand-in whose `filterTransactions` returns `[]`. The real one returns `{ transactions, newFraudContracts }`, and Home, AddressDetail and AddressToken read both fields. So every test boot that lands on one of those views throws inside its transaction loading, catches it, and logs `loadHomeTxs failed` or `loadTransactions failed`: the rest of that code, sorting the list and drawing the transaction rows, never runs in any of the boots in `tests/persistedFieldContract.test.js`, `tests/stateRecovery.test.js`, `tests/persistedEntryFloors.test.js` or `tests/addWalletSeparatePassword.test.js`. The roughly 900 logged errors per `make test` run are also the largest remaining cost of a boot. Found while working on https://git.eeqj.de/sneak/AutistMask/issues/428. ## Definition of done - [ ] The stand-in returns the shape the real `filterTransactions` returns. - [ ] A test boot onto Home, AddressDetail or AddressToken no longer logs a transaction-loading failure. - [ ] Any test that newly fails because that code now runs is fixed or reported, not loosened. - [ ] `TODO.md` updated in the same commit. - [ ] `make check` passes. Model: opus-5-5

clawbot referenced this issue

2026-10-04 14:43:03 +02:00

test: load the popup's libraries once per test file, not on every boot #430

clawbot referenced this issue from a commit

2026-10-05 01:32:43 +02:00

test: the popup boot's stand-in for filterTransactions returns the real shape (closes #429)

clawbot referenced a pull request that will close this issue

2026-10-05 01:34:26 +02:00

test: the popup boot's stand-in for filterTransactions returns the real shape #443

clawbot commented

2026-10-05 01:34:32 +02:00

Built in #443: the stand-in for filterTransactions in tests/support/popupBoot.js now returns { transactions, newFraudContracts }, and tests/persistedFieldContract.test.js boots onto Home, AddressDetail and AddressToken and asserts that neither loadHomeTxs failed nor loadTransactions failed is logged. No existing test failed once that code ran. make test time did not change measurably.

Model: opus-5-5

Built in https://git.eeqj.de/sneak/AutistMask/pulls/443: the stand-in for `filterTransactions` in `tests/support/popupBoot.js` now returns `{ transactions, newFraudContracts }`, and `tests/persistedFieldContract.test.js` boots onto Home, AddressDetail and AddressToken and asserts that neither `loadHomeTxs failed` nor `loadTransactions failed` is logged. No existing test failed once that code ran. `make test` time did not change measurably. Model: opus-5-5

clawbot closed this issue

2026-10-05 01:59:16 +02:00

clawbot referenced this issue from a commit

2026-10-05 01:59:18 +02:00

test: the popup boot's stand-in for filterTransactions returns the real shape (closes #429)

clawbot referenced this issue

2026-10-05 02:18:32 +02:00

fix: open no approval window for a site-connection prompt already answered #444

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: sneak/AutistMask#429