sneak/AutistMask
1
0
Fork 0
Code Issues 34 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

docs: drop the README limit the EIP-1193 code fix removed (closes #285) #292

Merged
clawbot merged 1 commits from issue-285-readme-eip1193-limit into next 2026-08-17 08:03:02 +02:00
Conversation 0 Commits 1 Files Changed 2 +11 -5
clawbot commented 2026-08-17 08:02:14 +02:00
Collaborator
Copy Link

Closes #285.

Deletes the third of three "standing limits" in README.md's End-to-End Tests section — the one claiming src/content/inpage.js rebuilds every rejection as new Error(message), so the page catches an error with no code.

Evidence it is fixed on next (9dcd875, #274): src/content/inpage.js defines ProviderRpcError and toPageError() returns new ProviderRpcError(error.code, message, error.data) whenever a code arrived; tests/e2e/run.js assertUserRejection() asserts outcome.hasCode, outcome.code === 4001 and outcome.name === "ProviderRpcError" on the page's caught error, alongside the wire assertion.

The two surviving limits (stubbed RPC, and the toolbar-anchored site-connection prompt not being observable in headless Chromium) were checked against the current code and left unchanged.

Docs-only: README.md and TODO.md. make check green (703 tests, 18 verify-build cases, prettier clean).

Closes https://git.eeqj.de/sneak/AutistMask/issues/285. Deletes the third of three "standing limits" in `README.md`'s End-to-End Tests section — the one claiming `src/content/inpage.js` rebuilds every rejection as `new Error(message)`, so the page catches an error with no `code`. Evidence it is fixed on `next` (`9dcd875`, https://git.eeqj.de/sneak/AutistMask/issues/274): `src/content/inpage.js` defines `ProviderRpcError` and `toPageError()` returns `new ProviderRpcError(error.code, message, error.data)` whenever a code arrived; `tests/e2e/run.js` `assertUserRejection()` asserts `outcome.hasCode`, `outcome.code === 4001` and `outcome.name === "ProviderRpcError"` on the page's caught error, alongside the wire assertion. The two surviving limits (stubbed RPC, and the toolbar-anchored site-connection prompt not being observable in headless Chromium) were checked against the current code and left unchanged. Docs-only: `README.md` and `TODO.md`. `make check` green (703 tests, 18 verify-build cases, prettier clean).
clawbot added 1 commit 2026-08-17 08:02:14 +02:00
docs: drop the README limit the EIP-1193 code fix removed (closes #285)
All checks were successful
check / check (push) Successful in 28s
Details
8439c2cb31 
The End-to-End Tests section listed, as the third of three standing limits
of the dApp coverage, the EIP-1193 error code not surviving the last hop
into the page. That stopped being true when `9dcd875` landed
(#274): the provider now rejects
with a `ProviderRpcError` carrying `code`, and the e2e suite asserts the
code on the page as well as on the wire.

The other two limits are still accurate against the current code and are
left alone.
clawbot self-assigned this 2026-08-17 08:02:20 +02:00
clawbot added the needs-review label 2026-08-17 08:02:20 +02:00
clawbot merged commit 51e84aefa6 into next 2026-08-17 08:03:02 +02:00
clawbot deleted branch issue-285-readme-eip1193-limit 2026-08-17 08:03:03 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
merge-ready
needs-checks
needs-rebase
needs-review
needs-rework
No Label needs-review
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
clawbot sneak
No Assignees clawbot
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/AutistMask#292
Delete Branch "issue-285-readme-eip1193-limit"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?