docs: README still documents the EIP-1193 code loss that #274 fixed #285

New Issue

clawbot · 2026-08-14T06:15:48+02:00

clawbot commented

2026-08-14 06:15:48 +02:00

README.md, in the End-to-End Tests section, lists as one of three standing limits of the dApp coverage:

> And the EIP-1193 error code does not survive the last hop: the rejection that crosses the boundary carries code 4001 and is asserted to, but src/content/inpage.js rebuilds it as new Error(message), so the calling page catches an error with no code property.

That stopped being true when #274 landed on next as 9dcd875. The provider now rejects with a ProviderRpcError carrying code, and the e2e suite asserts it on the page as well as on the wire — a current run of make test-e2e prints, for all four rejected flows:

# eth_requestAccounts rejection: code 4001 on the wire and on the page's ProviderRpcError

The commit did not touch README.md. So the file now advertises a defect the wallet does not have, in the section a reader consults to learn what the browser suites do and do not prove — the worst place for it, since the paragraph's whole job is to be the honest limits list.

Fix is the paragraph, not the code: delete the third limit and leave the other two, which are still accurate.

Found while wiring the suites into CI for #259; not fixed there, since it is outside that issue's scope.

`README.md`, in the End-to-End Tests section, lists as one of three standing limits of the dApp coverage: > And the EIP-1193 error code does not survive the last hop: the rejection that crosses the boundary carries code 4001 and is asserted to, but `src/content/inpage.js` rebuilds it as `new Error(message)`, so the calling page catches an error with no `code` property. That stopped being true when https://git.eeqj.de/sneak/AutistMask/issues/274 landed on `next` as `9dcd875`. The provider now rejects with a `ProviderRpcError` carrying `code`, and the e2e suite asserts it on the page as well as on the wire — a current run of `make test-e2e` prints, for all four rejected flows: # eth_requestAccounts rejection: code 4001 on the wire and on the page's ProviderRpcError The commit did not touch `README.md`. So the file now advertises a defect the wallet does not have, in the section a reader consults to learn what the browser suites do and do not prove — the worst place for it, since the paragraph's whole job is to be the honest limits list. Fix is the paragraph, not the code: delete the third limit and leave the other two, which are still accurate. Found while wiring the suites into CI for https://git.eeqj.de/sneak/AutistMask/issues/259; not fixed there, since it is outside that issue's scope.

clawbot referenced this issue

2026-08-14 06:26:48 +02:00

build: run the browser e2e suites in CI (closes #259) #291

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: sneak/AutistMask#285