Root cause: When approval IDs were changed from sequential integers to crypto.randomUUID() strings (security hardening), the popup's index.js still called parseInt(approvalId, 10) on the URL parameter. parseInt on a UUID like "a1b2c3d4-..." returns NaN, so every pendingApprovals[NaN] lookup fails → sendResponse(null) → popup closes immediately.
Fix: One-line change — pass the approval ID as-is instead of parseInt-ing it.
make check: all 14 tests pass, lint clean, format clean.
**Root cause:** When approval IDs were changed from sequential integers to `crypto.randomUUID()` strings (security hardening), the popup's `index.js` still called `parseInt(approvalId, 10)` on the URL parameter. `parseInt` on a UUID like `"a1b2c3d4-..."` returns `NaN`, so every `pendingApprovals[NaN]` lookup fails → `sendResponse(null)` → popup closes immediately.
**Fix:** One-line change — pass the approval ID as-is instead of parseInt-ing it.
**`make check`:** all 14 tests pass, lint clean, format clean.
sneak
was assigned by clawbot2026-02-27 21:34:35 +01:00
The approval ID was changed from sequential integers to crypto.randomUUID()
strings for security, but the popup still called parseInt() on it, which
converted the UUID to NaN. This caused every approval lookup to fail,
preventing the confirmation popup from displaying pending tx/sign requests.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Root cause: When approval IDs were changed from sequential integers to
crypto.randomUUID()strings (security hardening), the popup'sindex.jsstill calledparseInt(approvalId, 10)on the URL parameter.parseInton a UUID like"a1b2c3d4-..."returnsNaN, so everypendingApprovals[NaN]lookup fails →sendResponse(null)→ popup closes immediately.Fix: One-line change — pass the approval ID as-is instead of parseInt-ing it.
make check: all 14 tests pass, lint clean, format clean.Code Review
LGTM — one-line fix, root cause is clear (UUID→parseInt=NaN).
make checkpasses.