fix: pass UUID approval ID as string, not parseInt (closes #4) #18

clawbot · 2026-02-27T21:34:35+01:00

clawbot commented

2026-02-27 21:34:35 +01:00

Root cause: When approval IDs were changed from sequential integers to crypto.randomUUID() strings (security hardening), the popup's index.js still called parseInt(approvalId, 10) on the URL parameter. parseInt on a UUID like "a1b2c3d4-..." returns NaN, so every pendingApprovals[NaN] lookup fails → sendResponse(null) → popup closes immediately.

Fix: One-line change — pass the approval ID as-is instead of parseInt-ing it.

make check: all 14 tests pass, lint clean, format clean.

**Root cause:** When approval IDs were changed from sequential integers to `crypto.randomUUID()` strings (security hardening), the popup's `index.js` still called `parseInt(approvalId, 10)` on the URL parameter. `parseInt` on a UUID like `"a1b2c3d4-..."` returns `NaN`, so every `pendingApprovals[NaN]` lookup fails → `sendResponse(null)` → popup closes immediately. **Fix:** One-line change — pass the approval ID as-is instead of parseInt-ing it. **`make check`:** all 14 tests pass, lint clean, format clean.

sneak was assigned by clawbot

2026-02-27 21:34:35 +01:00

clawbot added 1 commit 2026-02-27 21:34:35 +01:00

fix: pass UUID approval ID as string, not parseInt (closes #4 )

check / check (push) Successful in 22s

Details

8b7d73cc35

The approval ID was changed from sequential integers to crypto.randomUUID()
strings for security, but the popup still called parseInt() on it, which
converted the UUID to NaN. This caused every approval lookup to fail,
preventing the confirmation popup from displaying pending tx/sign requests.

clawbot commented

2026-02-27 21:34:44 +01:00