sneak/AutistMask
1
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

no confirmation popup when doing a uniswap #4

New Issue
Closed
opened 2026-02-27 11:52:16 +01:00 by sneak · 3 comments
sneak commented 2026-02-27 11:52:16 +01:00
Owner
Copy Link

The uniswap UI shows "confirm in wallet" but no popover nor extension toolbar popup appear. This is obviously a blocking bug. Fortunately, when clicking the extension icon in the toolbar, the window that opens is on the confirmation screen, and entering the password and confirming does work. However, the toolbar popup (not a popover) needs to open when the dapp requests a signature.

The uniswap UI shows "confirm in wallet" but no popover nor extension toolbar popup appear. This is obviously a blocking bug. Fortunately, when clicking the extension icon in the toolbar, the window that opens *is* on the confirmation screen, and entering the password and confirming does work. However, the toolbar popup (not a popover) needs to open when the dapp requests a signature.
sneak commented 2026-02-27 21:29:24 +01:00
Author
Owner
Copy Link

Check that, now even opening the toolbar popup doesn't show the swap confirmation request. Please debug.

Check that, now even opening the toolbar popup doesn't show the swap confirmation request. Please debug.
clawbot was assigned by sneak 2026-02-27 21:29:29 +01:00
sneak added this to the 1.0.0 milestone 2026-02-27 21:29:38 +01:00
clawbot commented 2026-02-27 21:31:51 +01:00
Collaborator
Copy Link

Looking into this — checking the popup/confirmation flow now.

Looking into this — checking the popup/confirmation flow now.
clawbot commented 2026-02-27 21:34:44 +01:00
Collaborator
Copy Link

Found it. When approval IDs were changed from sequential integers to crypto.randomUUID() strings, the popup still called parseInt(approvalId, 10) on the URL param — which turns a UUID into NaN. Every approval lookup silently fails.

One-line fix in PR #18: #18

Found it. When approval IDs were changed from sequential integers to `crypto.randomUUID()` strings, the popup still called `parseInt(approvalId, 10)` on the URL param — which turns a UUID into `NaN`. Every approval lookup silently fails. One-line fix in PR #18: https://git.eeqj.de/sneak/AutistMask/pulls/18
sneak closed this issue 2026-02-27 21:50:28 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
bot

Agent's turn to work

  
merge-ready

   
needs-checks

   
needs-rebase

   
needs-review

   
needs-rework
No Label
bot
merge-ready
needs-checks
needs-rebase
needs-review
needs-rework
Milestone
Clear milestone
No items
No Milestone
1.0.0
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
clawbot
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sneak/AutistMask#4
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?