sneak/AutistMask
1
0
Fork 0
Code Issues 66 Pull Requests 3 Actions Packages Projects Releases Wiki Activity

fix: add fallback popup window for tx/sign approval requests (closes #4) #17

Merged
sneak merged 2 commits from fix/tx-approval-popup into main 2026-02-27 23:15:02 +01:00
Conversation 5 Commits 2 Files Changed 1
+16 -38
2 Commits
Author SHA1 Message Date
sneak 04ba926d43 Merge branch 'main' into fix/tx-approval-popup
check / check (push) Successful in 22s
Details
2026-02-27 23:10:58 +01:00
clawbot f2e44ff4ab fix: use windows.create() for tx/sign approval popups instead of openPopup()
check / check (push) Successful in 22s
Details 
action.openPopup() is unreliable when called from the background script
during an async message handler — it requires a user gesture context.
tx and sign approvals are triggered programmatically by dApp RPC calls,
not by user clicking the toolbar icon, so openPopup() fails silently.

Use windows.create() directly for tx/sign approvals, matching the
standard extension pattern (used by MetaMask and others). Site-connection
approvals retain openPopup() since they can fall back to the user
clicking the toolbar icon.

Also updates popup window dimensions to 360x600 to match the standard
popup viewport specified in README.

Closes #4
 2026-02-27 12:57:55 -08:00