sneak/AutistMask
1
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix: clear password field and error in showTxApproval #91

Merged
sneak merged 1 commits from fix/issue-85-clear-approve-tx-password into main 2026-02-28 22:24:55 +01:00
Conversation 2 Commits 1 Files Changed 1 +3
clawbot commented 2026-02-28 22:10:37 +01:00
Collaborator
Copy Link

Clears #approve-tx-password value and hides #approve-tx-error when the transaction approval view is shown, matching the pattern used in showSignApproval and confirmTx.show.

Closes #85

Clears `#approve-tx-password` value and hides `#approve-tx-error` when the transaction approval view is shown, matching the pattern used in `showSignApproval` and `confirmTx.show`. Closes #85
clawbot added 1 commit 2026-02-28 22:10:37 +01:00
fix: clear password field and error in showTxApproval
All checks were successful
check / check (push) Successful in 22s
Details
9b69a60cca 
Clears #approve-tx-password value and hides #approve-tx-error when the
transaction approval view is shown, matching the pattern used in
showSignApproval and confirmTx.show.

Closes #85
clawbot added the needs-reviewbot labels 2026-02-28 22:10:53 +01:00
clawbot commented 2026-02-28 22:10:53 +01:00
Author
Collaborator
Copy Link

Added two lines to showTxApproval() to clear #approve-tx-password value and hide #approve-tx-error, matching the existing pattern in showSignApproval() (line 344-345).

docker build . passes. Ready for review.

Added two lines to `showTxApproval()` to clear `#approve-tx-password` value and hide `#approve-tx-error`, matching the existing pattern in `showSignApproval()` (line 344-345). `docker build .` passes. Ready for review.
clawbot self-assigned this 2026-02-28 22:19:30 +01:00
clawbot added merge-ready and removed needs-reviewbot labels 2026-02-28 22:20:07 +01:00
clawbot removed their assignment 2026-02-28 22:20:08 +01:00
sneak was assigned by clawbot 2026-02-28 22:20:08 +01:00
clawbot commented 2026-02-28 22:20:16 +01:00
Author
Collaborator
Copy Link

Review: ✅ approved

The diff adds two lines to showTxApproval() that clear the password field and hide the error element, exactly matching the pattern in showSignApproval() (lines 344-345). This is the fix described in #85.

  • Correctness: ✅ uses the same $() helper and .classList.add("hidden") pattern as elsewhere
  • Edge cases: ✅ clearing an already-empty field or hiding an already-hidden element is harmless
  • Security: ✅ no sensitive data exposure, password field is properly cleared
  • Build: ✅ docker build . passes

Marked merge-ready, assigned to @sneak for merge.

**Review: ✅ approved** The diff adds two lines to `showTxApproval()` that clear the password field and hide the error element, exactly matching the pattern in `showSignApproval()` (lines 344-345). This is the fix described in #85. - Correctness: ✅ uses the same `$()` helper and `.classList.add("hidden")` pattern as elsewhere - Edge cases: ✅ clearing an already-empty field or hiding an already-hidden element is harmless - Security: ✅ no sensitive data exposure, password field is properly cleared - Build: ✅ `docker build .` passes Marked `merge-ready`, assigned to @sneak for merge.
sneak merged commit b826279d8f into main 2026-02-28 22:24:55 +01:00
sneak deleted branch fix/issue-85-clear-approve-tx-password 2026-02-28 22:24:55 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bot
Agent's turn to work
 merge-ready
needs-checks
needs-rebase
needs-review
needs-rework
No Label merge-ready
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
clawbot sneak
No Assignees sneak
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/AutistMask#91
Delete Branch "fix/issue-85-clear-approve-tx-password"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?