fix: replace confirm-tx password modal with inline field (closes #78) #83

clawbot · 2026-02-28T21:29:18+01:00

clawbot commented

2026-02-28 21:29:18 +01:00

Summary

Replaced the modal overlay password dialog in the confirm-tx view with an inline password field, matching the pattern used by approve-tx and approve-sign views
Removed the entire #password-modal div from index.html
Added inline password input with label and error area (with min-height to prevent layout shift) directly in the confirm-tx view
Changed button text from "Send" to "Sign & Send"
Button is now disabled during transaction processing to prevent double-clicks
Password field is cleared when the view is shown

Test plan

Open the send flow and verify the password field appears inline below transaction details
Verify wrong password shows error message inline without layout shift
Verify correct password signs and broadcasts the transaction
Verify the "Sign & Send" button is disabled during processing
Verify no modal overlay appears at any point
Run docker build . - passes (tests + lint + build)

Generated with Claude Code

## Summary - Replaced the modal overlay password dialog in the `confirm-tx` view with an inline password field, matching the pattern used by `approve-tx` and `approve-sign` views - Removed the entire `#password-modal` div from `index.html` - Added inline password input with label and error area (with `min-height` to prevent layout shift) directly in the confirm-tx view - Changed button text from "Send" to "Sign & Send" - Button is now disabled during transaction processing to prevent double-clicks - Password field is cleared when the view is shown ## Test plan - [ ] Open the send flow and verify the password field appears inline below transaction details - [ ] Verify wrong password shows error message inline without layout shift - [ ] Verify correct password signs and broadcasts the transaction - [ ] Verify the "Sign & Send" button is disabled during processing - [ ] Verify no modal overlay appears at any point - [ ] Run `docker build .` - passes (tests + lint + build) Generated with Claude Code

clawbot added the needs-review bot labels 2026-02-28 21:29:18 +01:00

clawbot added 1 commit 2026-02-28 21:29:18 +01:00

fix: replace confirm-tx password modal with inline field (closes #78 )

check / check (push) Successful in 22s

Details

73fa536ba2

Replace the modal overlay password dialog in the confirm-tx view with
an inline password field, matching the pattern used by approve-tx and
approve-sign views for consistency.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

clawbot commented

2026-02-28 21:30:24 +01:00

Changes

Replaced the confirm-tx password modal overlay with an inline password field, consistent with how approve-tx and approve-sign handle password input.

What changed

Removed the #password-modal div entirely from index.html
Added inline password input (#confirm-tx-password) with label and error area directly in the confirm-tx view, below transaction details and above the button
Error area uses min-h-[1.25rem] to prevent layout shift
Button text changed from "Send" to "Sign & Send"
Button disables during transaction processing (prevents double-clicks)
Password field clears when the view is shown
Removed showPasswordModal()/hidePasswordModal() functions from confirmTx.js

Consistency audit

Audited all 10 password input fields across 7 views. Filed 4 issues for remaining inconsistencies:

#84 — approve-tx and approve-sign error divs missing min-height (layout shift)
#85 — approve-tx password field not cleared when view is shown
#86 — export-privkey and delete-wallet buttons not disabled during async processing
#87 — three different error display patterns used for password validation

Verification

docker build . passes (tests, lint, build all green).

## Changes Replaced the `confirm-tx` password modal overlay with an inline password field, consistent with how `approve-tx` and `approve-sign` handle password input. ### What changed - Removed the `#password-modal` div entirely from `index.html` - Added inline password input (`#confirm-tx-password`) with label and error area directly in the confirm-tx view, below transaction details and above the button - Error area uses `min-h-[1.25rem]` to prevent layout shift - Button text changed from "Send" to "Sign & Send" - Button disables during transaction processing (prevents double-clicks) - Password field clears when the view is shown - Removed `showPasswordModal()`/`hidePasswordModal()` functions from `confirmTx.js` ### Consistency audit Audited all 10 password input fields across 7 views. Filed 4 issues for remaining inconsistencies: - #84 — approve-tx and approve-sign error divs missing min-height (layout shift) - #85 — approve-tx password field not cleared when view is shown - #86 — export-privkey and delete-wallet buttons not disabled during async processing - #87 — three different error display patterns used for password validation ### Verification `docker build .` passes (tests, lint, build all green).

sneak added 1 commit 2026-02-28 21:38:48 +01:00

Merge branch 'main' into fix/issue-78-inline-password

check / check (push) Successful in 22s

Details

0873c64c46

clawbot self-assigned this 2026-02-28 21:41:53 +01:00

clawbot added merge-ready and removed needs-review bot labels 2026-02-28 21:42:41 +01:00

clawbot removed their assignment 2026-02-28 21:42:42 +01:00

sneak was assigned by clawbot

2026-02-28 21:42:42 +01:00

clawbot commented

2026-02-28 21:42:51 +01:00

Review: ✅ merge-ready

Reviewed the full diff. Changes are clean and correct:

Modal removed, inline password field added in the confirm-tx view — consistent with approve-tx/approve-sign pattern
Error area uses min-h-[1.25rem] — no layout shift ✓
Password field cleared on view show ✓
Button disables during processing (prevents double-click) with finally block to re-enable ✓
Button text updated to "Sign & Send" ✓
All clickable elements have border + hover state ✓
Error messages are full sentences ✓
docker build . passes ✓

Consistency audit was thorough — filed #84, #85, #86, #87 for remaining issues. Good work.

Assigned to @sneak for merge.

## Review: ✅ merge-ready Reviewed the full diff. Changes are clean and correct: - **Modal removed**, inline password field added in the confirm-tx view — consistent with approve-tx/approve-sign pattern - Error area uses `min-h-[1.25rem]` — no layout shift ✓ - Password field cleared on view show ✓ - Button disables during processing (prevents double-click) with `finally` block to re-enable ✓ - Button text updated to "Sign & Send" ✓ - All clickable elements have border + hover state ✓ - Error messages are full sentences ✓ - `docker build .` passes ✓ Consistency audit was thorough — filed #84, #85, #86, #87 for remaining issues. Good work. Assigned to @sneak for merge.

sneak force-pushed fix/issue-78-inline-password from 0873c64c46 to 8f2bf9618e

2026-02-28 22:27:51 +01:00

Compare

sneak merged commit 699e080e3e into main

2026-02-28 22:28:19 +01:00

sneak deleted branch fix/issue-78-inline-password

2026-02-28 22:28:19 +01:00

sneak referenced this issue from a commit

2026-02-28 22:28:21 +01:00

Merge pull request 'fix: replace confirm-tx password modal with inline field (closes #78)' (#83) from fix/issue-78-inline-password into main

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: sneak/AutistMask#83