sneak/AutistMask
1
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix: show own labelled address for swap transactions (closes #55) #57

Merged
sneak merged 2 commits from fix/55-swap-tx-address into main 2026-02-28 18:16:13 +01:00
Conversation 1 Commits 2 Files Changed 2 +15 -6
clawbot commented 2026-02-28 17:57:26 +01:00
Collaborator
Copy Link

In transaction history lists, swap items were showing the contract address or an unlabelled address. This changes both home.js and addressDetail.js to show the user's own labelled wallet address for swap transactions instead.

Closes #55

In transaction history lists, swap items were showing the contract address or an unlabelled address. This changes both `home.js` and `addressDetail.js` to show the user's own labelled wallet address for swap transactions instead. Closes #55
sneak was assigned by clawbot 2026-02-28 17:57:26 +01:00
clawbot added 1 commit 2026-02-28 17:57:26 +01:00
fix: show own labelled address for swap transactions in tx lists
All checks were successful
check / check (push) Successful in 22s
Details
2c9a34aff6 
For swap transactions in the transaction history list views (home and
addressDetail), display the user's own labelled wallet address instead
of the contract/counterparty address. The contract address is not useful
in the list view — users need to see which of their addresses performed
the swap.

Closes #55
clawbot added the merge-ready label 2026-02-28 17:58:48 +01:00
clawbot commented 2026-02-28 17:58:55 +01:00
Author
Collaborator
Copy Link

Reviewed. make check passes (14/14 tests, lint clean, formatting clean) and docker build . succeeds.

The logic change is correct: for swap transactions (direction === "contract" + directionLabel === "Swap"), both home.js and addressDetail.js now show tx.from (the user's own wallet) instead of tx.to (the contract/router address). Non-swap contract interactions and regular sent/received transactions are unaffected by the added condition.

Marked merge-ready.

Reviewed. `make check` passes (14/14 tests, lint clean, formatting clean) and `docker build .` succeeds. The logic change is correct: for swap transactions (`direction === "contract"` + `directionLabel === "Swap"`), both `home.js` and `addressDetail.js` now show `tx.from` (the user's own wallet) instead of `tx.to` (the contract/router address). Non-swap contract interactions and regular sent/received transactions are unaffected by the added condition. Marked `merge-ready`.
sneak added 1 commit 2026-02-28 18:04:16 +01:00
Merge branch 'main' into fix/55-swap-tx-address
All checks were successful
check / check (push) Successful in 22s
Details
7c53c48cb1
sneak merged commit 82a7db63b5 into main 2026-02-28 18:16:13 +01:00
sneak deleted branch fix/55-swap-tx-address 2026-02-28 18:16:13 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bot
Agent's turn to work
 merge-ready
needs-checks
needs-rebase
needs-review
needs-rework
No Label merge-ready
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
clawbot sneak
No Assignees sneak
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/AutistMask#57
Delete Branch "fix/55-swap-tx-address"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?