in the transaction history lists, "swap" items show un-useful address #55
Labels
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: sneak/AutistMask#55
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
sometimes they show our (labelled) address in our wallet, sometimes they show the contract address. in the tx list, it should always show our labelled address, so we know which of our addresses was doing the swap. the counterparty isn't useful in the list view.
PR #56 submitted to fix this.
The issue was in
addressDetail.js— for swap/contract transactions, the counterparty was set totx.to(the contract address). Changed it to showtx.from(the user's own address) instead, so the list view shows which of your labelled wallets initiated the swap.Fixed in PR #57. Both transaction list views (
home.jsandaddressDetail.js) now show the user's own labelled wallet address for swap transactions instead of the contract address.make checkpasses cleanly.