sneak/AutistMask
1
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix: show own address for swap transactions in tx list #56

Closed
clawbot wants to merge 1 commits from fix/55-swap-show-own-address into main
pull from: fix/55-swap-show-own-address
merge into: sneak:main
Conversation 2 Commits 1 Files Changed 1 +5 -3
clawbot commented 2026-02-28 17:57:16 +01:00
Collaborator
Copy Link

For swap/contract interactions in the transaction history list, display the user's own (labelled) address instead of the contract address. This way users can see which of their addresses initiated the swap.

The counterparty contract address isn't useful in the list view — what matters is knowing which wallet performed the swap.

Fixes #55

For swap/contract interactions in the transaction history list, display the user's own (labelled) address instead of the contract address. This way users can see which of their addresses initiated the swap. The counterparty contract address isn't useful in the list view — what matters is knowing which wallet performed the swap. Fixes #55
clawbot added 1 commit 2026-02-28 17:57:17 +01:00
fix: show user's own address for swap transactions in tx list
All checks were successful
check / check (push) Successful in 22s
Details
868f7a6ff8 
For swap/contract interactions, display the user's own (labelled)
address instead of the contract address, so users can see which
of their addresses initiated the swap.

Fixes #55
clawbot added the needs-review label 2026-02-28 18:00:18 +01:00
clawbot commented 2026-02-28 18:00:29 +01:00
Author
Collaborator
Copy Link

Review: ✅ LGTM

make check: all tests pass, lint clean, formatting clean.
docker build .: succeeds.

Code review: The change correctly separates contract direction from sent — for contract interactions (swaps), tx.from (the user's own address) is shown instead of tx.to (the contract address). This is a clear UX improvement; users want to see which wallet initiated the swap, not the router contract.

The logic is clean and the ternary chain is well-formatted. Single commit, minimal diff. Ready to merge.

→ Labelled needs-review → merge-ready. Assigning to @sneak.

## Review: ✅ LGTM **`make check`**: all tests pass, lint clean, formatting clean. **`docker build .`**: succeeds. **Code review**: The change correctly separates `contract` direction from `sent` — for contract interactions (swaps), `tx.from` (the user's own address) is shown instead of `tx.to` (the contract address). This is a clear UX improvement; users want to see which wallet initiated the swap, not the router contract. The logic is clean and the ternary chain is well-formatted. Single commit, minimal diff. Ready to merge. → Labelled `needs-review` → `merge-ready`. Assigning to @sneak.
clawbot added merge-ready and removed needs-review labels 2026-02-28 18:00:36 +01:00
sneak was assigned by clawbot 2026-02-28 18:00:37 +01:00
clawbot commented 2026-02-28 18:01:18 +01:00
Author
Collaborator
Copy Link

Closing as duplicate of #57.

Closing as duplicate of #57.
clawbot closed this pull request 2026-02-28 18:01:19 +01:00
All checks were successful
check / check (push) Successful in 22s
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bot
Agent's turn to work
 merge-ready
needs-checks
needs-rebase
needs-review
needs-rework
No Label merge-ready
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
clawbot sneak
No Assignees sneak
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/AutistMask#56
Delete Branch "fix/55-swap-show-own-address"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?