For swap/contract interactions in the transaction history list, display the user's own (labelled) address instead of the contract address. This way users can see which of their addresses initiated the swap.
The counterparty contract address isn't useful in the list view — what matters is knowing which wallet performed the swap.
For swap/contract interactions in the transaction history list, display the user's own (labelled) address instead of the contract address. This way users can see which of their addresses initiated the swap.
The counterparty contract address isn't useful in the list view — what matters is knowing which wallet performed the swap.
Fixes #55
For swap/contract interactions, display the user's own (labelled)
address instead of the contract address, so users can see which
of their addresses initiated the swap.
Fixes#55
make check: all tests pass, lint clean, formatting clean. docker build .: succeeds.
Code review: The change correctly separates contract direction from sent — for contract interactions (swaps), tx.from (the user's own address) is shown instead of tx.to (the contract address). This is a clear UX improvement; users want to see which wallet initiated the swap, not the router contract.
The logic is clean and the ternary chain is well-formatted. Single commit, minimal diff. Ready to merge.
→ Labelled needs-review → merge-ready. Assigning to @sneak.
## Review: ✅ LGTM
**`make check`**: all tests pass, lint clean, formatting clean.
**`docker build .`**: succeeds.
**Code review**: The change correctly separates `contract` direction from `sent` — for contract interactions (swaps), `tx.from` (the user's own address) is shown instead of `tx.to` (the contract address). This is a clear UX improvement; users want to see which wallet initiated the swap, not the router contract.
The logic is clean and the ternary chain is well-formatted. Single commit, minimal diff. Ready to merge.
→ Labelled `needs-review` → `merge-ready`. Assigning to @sneak.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
For swap/contract interactions in the transaction history list, display the user's own (labelled) address instead of the contract address. This way users can see which of their addresses initiated the swap.
The counterparty contract address isn't useful in the list view — what matters is knowing which wallet performed the swap.
Fixes #55
Review: ✅ LGTM
make check: all tests pass, lint clean, formatting clean.docker build .: succeeds.Code review: The change correctly separates
contractdirection fromsent— for contract interactions (swaps),tx.from(the user's own address) is shown instead oftx.to(the contract address). This is a clear UX improvement; users want to see which wallet initiated the swap, not the router contract.The logic is clean and the ternary chain is well-formatted. Single commit, minimal diff. Ready to merge.
→ Labelled
needs-review→merge-ready. Assigning to @sneak.Closing as duplicate of #57.
Pull request closed