sneak/AutistMask
1
0
Fork 0
Code Issues 24 Pull Requests 3 Actions 48 Packages Projects Releases Wiki Activity

fix: Back from Settings does nothing once when the screen under it on the Back stack is Settings itself #481

New Issue
Open
opened 2026-10-06 21:40:10 +02:00 by clawbot · 2 comments
clawbot commented 2026-10-06 21:40:10 +02:00
Collaborator
Copy Link
Copy Source

Settings, [recovery phrase], then the settings gear leaves the Back stack ending in Settings while Settings is showing. The first Back from Settings shows Settings again, so the press seems to do nothing; the second goes Home.

This already happens after a reopen. Close and reopen the popup at that point: the stack restored after a reopen (#224) is cut at the recovery phrase screen, which leaves Settings on top. The delete wallet screen leads to the same state. With #479 it also happens without the reopen.

Steps: Settings, [recovery phrase], settings gear, close and reopen the popup, Back.

Unverified: found by reading the code, not reproduced in a browser.

Definition of done

  • Back from Settings never lands on Settings itself.
  • make check passes.

Model: opus-5-5

Settings, `[recovery phrase]`, then the settings gear leaves the Back stack ending in Settings while Settings is showing. The first Back from Settings shows Settings again, so the press seems to do nothing; the second goes Home. This already happens after a reopen. Close and reopen the popup at that point: the stack restored after a reopen (https://git.eeqj.de/sneak/AutistMask/issues/224) is cut at the recovery phrase screen, which leaves Settings on top. The delete wallet screen leads to the same state. With https://git.eeqj.de/sneak/AutistMask/pulls/479 it also happens without the reopen. Steps: Settings, `[recovery phrase]`, settings gear, close and reopen the popup, Back. Unverified: found by reading the code, not reproduced in a browser. ## Definition of done - [ ] Back from Settings never lands on Settings itself. - [ ] `make check` passes. Model: opus-5-5
clawbot commented 2026-10-07 03:43:36 +02:00
Author
Collaborator
Copy Link
Copy Source

Plan: one fix in the Back-stack code that covers every path (the recovery phrase and delete screens left by the gear, and the stack restored after a reopen), so Back from Settings never shows Settings again. Reproduced in jest first; tests for each path; the rest of Back traced unchanged.

Model: opus-5-5

Plan: one fix in the Back-stack code that covers every path (the recovery phrase and delete screens left by the gear, and the stack restored after a reopen), so Back from Settings never shows Settings again. Reproduced in jest first; tests for each path; the rest of Back traced unchanged. Model: opus-5-5
clawbot commented 2026-10-07 04:00:02 +02:00
Author
Collaborator
Copy Link
Copy Source

Fixed in #486: Back now skips any entry for the screen already showing, which covers the recovery phrase and delete wallet screens left by the gear and the stack restored after a reopen.

Model: opus-5-5

Fixed in https://git.eeqj.de/sneak/AutistMask/pulls/486: Back now skips any entry for the screen already showing, which covers the recovery phrase and delete wallet screens left by the gear and the stack restored after a reopen. Model: opus-5-5
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
critical
Extremely important: data loss, a security hole, production down, or basic use impossible
 merge-ready
needs-checks
needs-rebase
needs-review
needs-rework
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
clawbot sneak (Jeffrey Paul)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/AutistMask#481