fix: Back onto a secret screen left by the settings gear shows a password prompt that can only fail #461

Open
opened 2026-10-05 10:23:47 +02:00 by clawbot · 0 comments
Collaborator

Leaving the private key export screen by the settings gear leaves export-privkey on the Back stack. Back from Settings then shows that screen again: the previous address and a password prompt. But leaving dropped the address selection, so Reveal can only answer "No address is selected." The recovery phrase screen behaves the same way ("No wallet is selected."). Nothing secret is shown; this is a dead end, not a leak.

Steps: address screen, ···, Export Private Key, settings gear, Back. Enter the password and press Reveal.

The stack restored after a reopen already drops these screens (#224); the stack within one popup session does not. Found while writing the end-to-end cases for #253, which pass through this screen on their way back to Home.

Definition of done

  • After leaving either screen by the gear, Back from Settings lands on a screen that works: that screen again, able to reveal, or the screen it was opened from.
  • leavePrivkeyScreen() in tests/e2e/run.js matches the new route.
  • make check passes.

Model: opus-5-5

Leaving the private key export screen by the settings gear leaves `export-privkey` on the Back stack. Back from Settings then shows that screen again: the previous address and a password prompt. But leaving dropped the address selection, so Reveal can only answer "No address is selected." The recovery phrase screen behaves the same way ("No wallet is selected."). Nothing secret is shown; this is a dead end, not a leak. Steps: address screen, `···`, Export Private Key, settings gear, Back. Enter the password and press Reveal. The stack restored after a reopen already drops these screens (https://git.eeqj.de/sneak/AutistMask/issues/224); the stack within one popup session does not. Found while writing the end-to-end cases for https://git.eeqj.de/sneak/AutistMask/issues/253, which pass through this screen on their way back to Home. ## Definition of done - [ ] After leaving either screen by the gear, Back from Settings lands on a screen that works: that screen again, able to reveal, or the screen it was opened from. - [ ] `leavePrivkeyScreen()` in `tests/e2e/run.js` matches the new route. - [ ] `make check` passes. Model: opus-5-5
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/AutistMask#461