sneak/AutistMask
1
0
Fork 0
Code Issues 25 Pull Requests 3 Actions 33 Packages Projects Releases Wiki Activity

fix: Back onto the delete wallet screen left by the settings gear shows a password prompt that can only fail #480

New Issue
Open
opened 2026-10-06 21:40:10 +02:00 by clawbot · 2 comments
clawbot commented 2026-10-06 21:40:10 +02:00
Collaborator
Copy Link
Copy Source

Leaving the delete wallet screen (delete-wallet-confirm) by the settings gear leaves it on the Back stack, but leaving drops its wallet selection. Back from Settings shows the screen again, with the wallet name and a password prompt, and Delete can only answer "No wallet selected for deletion." The lost-password screen (delete-wallet-lost-password) drops its selection the same way.

Steps: Settings, [x] on a wallet, settings gear, Back. Enter the password and press Delete.

This is the defect of #461 on a different screen. #479 fixes it for the two secret screens: each one's leave handler takes the screen off the Back stack.

Unverified: found by reading the code, not reproduced in a browser.

Definition of done

  • After leaving either delete screen by the gear, Back from Settings lands on a screen that works.
  • make check passes.

Model: opus-5-5

Leaving the delete wallet screen (`delete-wallet-confirm`) by the settings gear leaves it on the Back stack, but leaving drops its wallet selection. Back from Settings shows the screen again, with the wallet name and a password prompt, and Delete can only answer "No wallet selected for deletion." The lost-password screen (`delete-wallet-lost-password`) drops its selection the same way. Steps: Settings, `[x]` on a wallet, settings gear, Back. Enter the password and press Delete. This is the defect of https://git.eeqj.de/sneak/AutistMask/issues/461 on a different screen. https://git.eeqj.de/sneak/AutistMask/pulls/479 fixes it for the two secret screens: each one's leave handler takes the screen off the Back stack. Unverified: found by reading the code, not reproduced in a browser. ## Definition of done - [ ] After leaving either delete screen by the gear, Back from Settings lands on a screen that works. - [ ] `make check` passes. Model: opus-5-5
clawbot commented 2026-10-07 01:43:43 +02:00
Author
Collaborator
Copy Link
Copy Source

Plan: the delete wallet and lost-password screens take themselves off the top of the Back stack when left, the pattern #479 used for the secret screens. Reproduced first, jest tests that fail without each check. #481 follows as its own unit.

Model: opus-5-5

Plan: the delete wallet and lost-password screens take themselves off the top of the Back stack when left, the pattern https://git.eeqj.de/sneak/AutistMask/pulls/479 used for the secret screens. Reproduced first, jest tests that fail without each check. https://git.eeqj.de/sneak/AutistMask/issues/481 follows as its own unit. Model: opus-5-5
clawbot commented 2026-10-07 02:05:50 +02:00
Author
Collaborator
Copy Link
Copy Source

Fixed in #484: both delete screens take themselves off the Back stack when left, so Back from Settings after the gear no longer shows one with no wallet chosen. Back from Settings then stays on Settings once, which is #481.

Model: opus-5-5

Fixed in https://git.eeqj.de/sneak/AutistMask/pulls/484: both delete screens take themselves off the Back stack when left, so Back from Settings after the gear no longer shows one with no wallet chosen. Back from Settings then stays on Settings once, which is https://git.eeqj.de/sneak/AutistMask/issues/481. Model: opus-5-5
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
critical
Extremely important: data loss, a security hole, production down, or basic use impossible
 merge-ready
needs-checks
needs-rebase
needs-review
needs-rework
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
clawbot sneak (Jeffrey Paul)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/AutistMask#480