Compare commits
6 Commits
8379ab4685
...
fix/issue-
| Author | SHA1 | Date | |
|---|---|---|---|
| b9c3d99fed | |||
| e8ede7010a | |||
| a2fbb0e30d | |||
| 24464ffe33 | |||
| 34c66d19c4 | |||
|
|
9a7aa1f4fc |
@@ -422,11 +422,6 @@
|
|||||||
class="border border-border p-1 w-full font-mono text-sm bg-bg text-fg"
|
class="border border-border p-1 w-full font-mono text-sm bg-bg text-fg"
|
||||||
placeholder="Address (0x...) or ENS name"
|
placeholder="Address (0x...) or ENS name"
|
||||||
/>
|
/>
|
||||||
<div
|
|
||||||
id="send-to-error"
|
|
||||||
class="text-xs"
|
|
||||||
style="min-height: 1.25rem; color: #cc0000"
|
|
||||||
></div>
|
|
||||||
</div>
|
</div>
|
||||||
<div class="mb-2">
|
<div class="mb-2">
|
||||||
<div class="flex justify-between mb-1">
|
<div class="flex justify-between mb-1">
|
||||||
@@ -642,9 +637,16 @@
|
|||||||
<div class="flex justify-center mb-3">
|
<div class="flex justify-center mb-3">
|
||||||
<canvas id="receive-qr"></canvas>
|
<canvas id="receive-qr"></canvas>
|
||||||
</div>
|
</div>
|
||||||
<div class="border border-border p-2 break-all mb-3 text-xs">
|
<div
|
||||||
<span id="receive-dot"></span>
|
id="receive-ens"
|
||||||
<span id="receive-address" class="select-all"></span>
|
class="font-bold mb-1 hidden flex items-center"
|
||||||
|
></div>
|
||||||
|
<div
|
||||||
|
class="border border-border p-2 break-all mb-3 text-xs cursor-pointer"
|
||||||
|
title="Click to copy"
|
||||||
|
>
|
||||||
|
<span id="receive-address-dot"></span>
|
||||||
|
<span id="receive-address-full"></span>
|
||||||
<span id="receive-etherscan-link"></span>
|
<span id="receive-etherscan-link"></span>
|
||||||
</div>
|
</div>
|
||||||
<button
|
<button
|
||||||
|
|||||||
@@ -12,7 +12,7 @@ const {
|
|||||||
balanceLine,
|
balanceLine,
|
||||||
} = require("./helpers");
|
} = require("./helpers");
|
||||||
const { state, currentAddress, saveState } = require("../../shared/state");
|
const { state, currentAddress, saveState } = require("../../shared/state");
|
||||||
const { TOKEN_BY_ADDRESS } = require("../../shared/tokenList");
|
const { TOKEN_BY_ADDRESS, resolveSymbol } = require("../../shared/tokenList");
|
||||||
const {
|
const {
|
||||||
formatUsd,
|
formatUsd,
|
||||||
getPrice,
|
getPrice,
|
||||||
@@ -96,14 +96,11 @@ function show() {
|
|||||||
const tb = (addr.tokenBalances || []).find(
|
const tb = (addr.tokenBalances || []).find(
|
||||||
(t) => t.address.toLowerCase() === tokenId.toLowerCase(),
|
(t) => t.address.toLowerCase() === tokenId.toLowerCase(),
|
||||||
);
|
);
|
||||||
const tracked = (state.trackedTokens || []).find(
|
symbol = resolveSymbol(
|
||||||
(t) => t.address.toLowerCase() === tokenId.toLowerCase(),
|
tokenId,
|
||||||
|
addr.tokenBalances,
|
||||||
|
state.trackedTokens,
|
||||||
);
|
);
|
||||||
symbol =
|
|
||||||
(tb && tb.symbol) ||
|
|
||||||
(tracked && tracked.symbol) ||
|
|
||||||
(knownToken && knownToken.symbol) ||
|
|
||||||
"?";
|
|
||||||
amount = tb ? parseFloat(tb.balance || "0") : 0;
|
amount = tb ? parseFloat(tb.balance || "0") : 0;
|
||||||
price = getPrice(symbol);
|
price = getPrice(symbol);
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -1,4 +1,10 @@
|
|||||||
const { $, showView, showFlash, addressDotHtml } = require("./helpers");
|
const {
|
||||||
|
$,
|
||||||
|
showView,
|
||||||
|
showFlash,
|
||||||
|
addressDotHtml,
|
||||||
|
escapeHtml,
|
||||||
|
} = require("./helpers");
|
||||||
const { state, currentAddress } = require("../../shared/state");
|
const { state, currentAddress } = require("../../shared/state");
|
||||||
const QRCode = require("qrcode");
|
const QRCode = require("qrcode");
|
||||||
|
|
||||||
@@ -12,8 +18,17 @@ const EXT_ICON =
|
|||||||
function show() {
|
function show() {
|
||||||
const addr = currentAddress();
|
const addr = currentAddress();
|
||||||
const address = addr ? addr.address : "";
|
const address = addr ? addr.address : "";
|
||||||
$("receive-dot").innerHTML = address ? addressDotHtml(address) : "";
|
$("receive-address-dot").innerHTML = address ? addressDotHtml(address) : "";
|
||||||
$("receive-address").textContent = address;
|
$("receive-address-full").textContent = address;
|
||||||
|
$("receive-address-full").dataset.full = address;
|
||||||
|
const ensName = addr ? addr.ensName || null : null;
|
||||||
|
const ensEl = $("receive-ens");
|
||||||
|
if (ensName) {
|
||||||
|
ensEl.innerHTML = addressDotHtml(address) + escapeHtml(ensName);
|
||||||
|
ensEl.classList.remove("hidden");
|
||||||
|
} else {
|
||||||
|
ensEl.classList.add("hidden");
|
||||||
|
}
|
||||||
const link = address ? `https://etherscan.io/address/${address}` : "";
|
const link = address ? `https://etherscan.io/address/${address}` : "";
|
||||||
$("receive-etherscan-link").innerHTML = link
|
$("receive-etherscan-link").innerHTML = link
|
||||||
? `<a href="${link}" target="_blank" rel="noopener" class="inline-flex items-center">${EXT_ICON}</a>`
|
? `<a href="${link}" target="_blank" rel="noopener" class="inline-flex items-center">${EXT_ICON}</a>`
|
||||||
@@ -50,8 +65,16 @@ function show() {
|
|||||||
}
|
}
|
||||||
|
|
||||||
function init(ctx) {
|
function init(ctx) {
|
||||||
|
$("receive-address-full").addEventListener("click", () => {
|
||||||
|
const addr = $("receive-address-full").dataset.full;
|
||||||
|
if (addr) {
|
||||||
|
navigator.clipboard.writeText(addr);
|
||||||
|
showFlash("Copied!");
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
$("btn-receive-copy").addEventListener("click", () => {
|
$("btn-receive-copy").addEventListener("click", () => {
|
||||||
const addr = $("receive-address").textContent;
|
const addr = $("receive-address-full").dataset.full;
|
||||||
if (addr) {
|
if (addr) {
|
||||||
navigator.clipboard.writeText(addr);
|
navigator.clipboard.writeText(addr);
|
||||||
showFlash("Copied!");
|
showFlash("Copied!");
|
||||||
|
|||||||
@@ -10,108 +10,7 @@ const {
|
|||||||
const { state, currentAddress } = require("../../shared/state");
|
const { state, currentAddress } = require("../../shared/state");
|
||||||
let ctx;
|
let ctx;
|
||||||
const { getProvider } = require("../../shared/balances");
|
const { getProvider } = require("../../shared/balances");
|
||||||
const { KNOWN_SYMBOLS, TOKEN_BY_ADDRESS } = require("../../shared/tokenList");
|
const { KNOWN_SYMBOLS, resolveSymbol } = require("../../shared/tokenList");
|
||||||
const { getAddress } = require("ethers");
|
|
||||||
|
|
||||||
const ZERO_ADDRESS = "0x0000000000000000000000000000000000000000";
|
|
||||||
|
|
||||||
/**
|
|
||||||
* Validate a destination address string.
|
|
||||||
* Returns { valid: true } or { valid: false, error: "..." }.
|
|
||||||
*/
|
|
||||||
function validateToAddress(value) {
|
|
||||||
const v = value.trim();
|
|
||||||
if (!v) return { valid: false, error: "" };
|
|
||||||
|
|
||||||
// ENS names: contains a dot and doesn't start with 0x
|
|
||||||
if (v.includes(".") && !v.startsWith("0x")) {
|
|
||||||
// Basic ENS format check: at least one label before and after dot
|
|
||||||
if (/^[a-zA-Z0-9-]+(\.[a-zA-Z0-9-]+)+$/.test(v)) {
|
|
||||||
return { valid: true };
|
|
||||||
}
|
|
||||||
return {
|
|
||||||
valid: false,
|
|
||||||
error: "Please enter a valid ENS name.",
|
|
||||||
};
|
|
||||||
}
|
|
||||||
|
|
||||||
// Must look like an Ethereum address
|
|
||||||
if (!/^0x[0-9a-fA-F]{40}$/.test(v)) {
|
|
||||||
return {
|
|
||||||
valid: false,
|
|
||||||
error: "Please enter a valid Ethereum address.",
|
|
||||||
};
|
|
||||||
}
|
|
||||||
|
|
||||||
// Reject zero address
|
|
||||||
if (v.toLowerCase() === ZERO_ADDRESS) {
|
|
||||||
return {
|
|
||||||
valid: false,
|
|
||||||
error: "Sending to the zero address is not allowed.",
|
|
||||||
};
|
|
||||||
}
|
|
||||||
|
|
||||||
// EIP-55 checksum validation: all-lowercase is ok, otherwise must match checksum
|
|
||||||
if (v !== v.toLowerCase()) {
|
|
||||||
try {
|
|
||||||
const checksummed = getAddress(v);
|
|
||||||
if (checksummed !== v) {
|
|
||||||
return {
|
|
||||||
valid: false,
|
|
||||||
error: "Address checksum is invalid. Please double-check the address.",
|
|
||||||
};
|
|
||||||
}
|
|
||||||
} catch {
|
|
||||||
return {
|
|
||||||
valid: false,
|
|
||||||
error: "Address checksum is invalid. Please double-check the address.",
|
|
||||||
};
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
// Warn if sending to own address
|
|
||||||
const addr = currentAddress();
|
|
||||||
if (addr && v.toLowerCase() === addr.address.toLowerCase()) {
|
|
||||||
// Allow but will warn — we return valid with a warning
|
|
||||||
return {
|
|
||||||
valid: true,
|
|
||||||
warning: "This is your own address. Are you sure?",
|
|
||||||
};
|
|
||||||
}
|
|
||||||
|
|
||||||
return { valid: true };
|
|
||||||
}
|
|
||||||
|
|
||||||
function updateToValidation() {
|
|
||||||
const input = $("send-to");
|
|
||||||
const errorEl = $("send-to-error");
|
|
||||||
const btn = $("btn-send-review");
|
|
||||||
const value = input.value.trim();
|
|
||||||
|
|
||||||
if (!value) {
|
|
||||||
errorEl.textContent = "";
|
|
||||||
btn.disabled = true;
|
|
||||||
btn.classList.add("opacity-50");
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
const result = validateToAddress(value);
|
|
||||||
if (!result.valid) {
|
|
||||||
errorEl.textContent = result.error;
|
|
||||||
errorEl.style.color = "#cc0000";
|
|
||||||
btn.disabled = true;
|
|
||||||
btn.classList.add("opacity-50");
|
|
||||||
} else if (result.warning) {
|
|
||||||
errorEl.textContent = result.warning;
|
|
||||||
errorEl.style.color = "#b8860b";
|
|
||||||
btn.disabled = false;
|
|
||||||
btn.classList.remove("opacity-50");
|
|
||||||
} else {
|
|
||||||
errorEl.textContent = "";
|
|
||||||
btn.disabled = false;
|
|
||||||
btn.classList.remove("opacity-50");
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
const EXT_ICON =
|
const EXT_ICON =
|
||||||
`<span style="display:inline-block;width:10px;height:10px;margin-left:4px;vertical-align:middle">` +
|
`<span style="display:inline-block;width:10px;height:10px;margin-left:4px;vertical-align:middle">` +
|
||||||
@@ -174,15 +73,11 @@ function updateSendBalance() {
|
|||||||
const tb = (addr.tokenBalances || []).find(
|
const tb = (addr.tokenBalances || []).find(
|
||||||
(t) => t.address.toLowerCase() === token.toLowerCase(),
|
(t) => t.address.toLowerCase() === token.toLowerCase(),
|
||||||
);
|
);
|
||||||
const knownToken = TOKEN_BY_ADDRESS.get(token.toLowerCase());
|
const symbol = resolveSymbol(
|
||||||
const tracked = (state.trackedTokens || []).find(
|
token,
|
||||||
(t) => t.address.toLowerCase() === token.toLowerCase(),
|
addr.tokenBalances,
|
||||||
|
state.trackedTokens,
|
||||||
);
|
);
|
||||||
const symbol =
|
|
||||||
(tb && tb.symbol) ||
|
|
||||||
(tracked && tracked.symbol) ||
|
|
||||||
(knownToken && knownToken.symbol) ||
|
|
||||||
"?";
|
|
||||||
const bal = tb ? tb.balance || "0" : "0";
|
const bal = tb ? tb.balance || "0" : "0";
|
||||||
$("send-balance").textContent =
|
$("send-balance").textContent =
|
||||||
"Current balance: " + bal + " " + symbol;
|
"Current balance: " + bal + " " + symbol;
|
||||||
@@ -193,13 +88,6 @@ function init(_ctx) {
|
|||||||
ctx = _ctx;
|
ctx = _ctx;
|
||||||
$("send-token").addEventListener("change", updateSendBalance);
|
$("send-token").addEventListener("change", updateSendBalance);
|
||||||
|
|
||||||
// Initial state: disable review button until address is entered
|
|
||||||
$("btn-send-review").disabled = true;
|
|
||||||
$("btn-send-review").classList.add("opacity-50");
|
|
||||||
|
|
||||||
// Validate address on input
|
|
||||||
$("send-to").addEventListener("input", updateToValidation);
|
|
||||||
|
|
||||||
$("btn-send-review").addEventListener("click", async () => {
|
$("btn-send-review").addEventListener("click", async () => {
|
||||||
const to = $("send-to").value.trim();
|
const to = $("send-to").value.trim();
|
||||||
const amount = $("send-amount").value.trim();
|
const amount = $("send-amount").value.trim();
|
||||||
@@ -207,15 +95,6 @@ function init(_ctx) {
|
|||||||
showFlash("Please enter a recipient address.");
|
showFlash("Please enter a recipient address.");
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
// Re-validate before proceeding
|
|
||||||
const validation = validateToAddress(to);
|
|
||||||
if (!validation.valid) {
|
|
||||||
showFlash(
|
|
||||||
validation.error || "Please enter a valid Ethereum address.",
|
|
||||||
);
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
if (!amount || isNaN(parseFloat(amount)) || parseFloat(amount) <= 0) {
|
if (!amount || isNaN(parseFloat(amount)) || parseFloat(amount) <= 0) {
|
||||||
showFlash("Please enter a valid amount.");
|
showFlash("Please enter a valid amount.");
|
||||||
return;
|
return;
|
||||||
@@ -249,15 +128,11 @@ function init(_ctx) {
|
|||||||
const tb = (addr.tokenBalances || []).find(
|
const tb = (addr.tokenBalances || []).find(
|
||||||
(t) => t.address.toLowerCase() === token.toLowerCase(),
|
(t) => t.address.toLowerCase() === token.toLowerCase(),
|
||||||
);
|
);
|
||||||
const knownTk = TOKEN_BY_ADDRESS.get(token.toLowerCase());
|
tokenSymbol = resolveSymbol(
|
||||||
const trackedTk = (state.trackedTokens || []).find(
|
token,
|
||||||
(t) => t.address.toLowerCase() === token.toLowerCase(),
|
addr.tokenBalances,
|
||||||
|
state.trackedTokens,
|
||||||
);
|
);
|
||||||
tokenSymbol =
|
|
||||||
(tb && tb.symbol) ||
|
|
||||||
(trackedTk && trackedTk.symbol) ||
|
|
||||||
(knownTk && knownTk.symbol) ||
|
|
||||||
"?";
|
|
||||||
tokenBalance = tb ? tb.balance || "0" : "0";
|
tokenBalance = tb ? tb.balance || "0" : "0";
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -3645,10 +3645,27 @@ async function getTopTokenPrices(n) {
|
|||||||
return prices;
|
return prices;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Resolve a token symbol from multiple sources, never returning "?".
|
||||||
|
function resolveSymbol(tokenAddress, tokenBalances, trackedTokens) {
|
||||||
|
const lower = (tokenAddress || "").toLowerCase();
|
||||||
|
const tb = (tokenBalances || []).find(
|
||||||
|
(t) => t.address.toLowerCase() === lower,
|
||||||
|
);
|
||||||
|
if (tb && tb.symbol) return tb.symbol;
|
||||||
|
const known = TOKEN_BY_ADDRESS.get(lower);
|
||||||
|
if (known && known.symbol) return known.symbol;
|
||||||
|
const tracked = (trackedTokens || []).find(
|
||||||
|
(t) => t.address.toLowerCase() === lower,
|
||||||
|
);
|
||||||
|
if (tracked && tracked.symbol) return tracked.symbol;
|
||||||
|
return lower.slice(0, 10) + "\u2026";
|
||||||
|
}
|
||||||
|
|
||||||
module.exports = {
|
module.exports = {
|
||||||
TOKENS,
|
TOKENS,
|
||||||
TOKEN_BY_ADDRESS,
|
TOKEN_BY_ADDRESS,
|
||||||
KNOWN_SYMBOLS,
|
KNOWN_SYMBOLS,
|
||||||
getTopTokens,
|
getTopTokens,
|
||||||
getTopTokenPrices,
|
getTopTokenPrices,
|
||||||
|
resolveSymbol,
|
||||||
};
|
};
|
||||||
|
|||||||
Reference in New Issue
Block a user