The receive view was using raw textContent and a manually constructed color dot instead of the shared formatAddressHtml helper used by other views. This violated the display consistency policy ("Same data formatted identically across all screens").
Changes
Use formatAddressHtml() to render address with color dot, title (e.g. "Wallet 1 — Address 1"), and ENS name — matching addressDetail
Make the address block itself click-to-copy (matching policy: "Clicking any address copies the full untruncated value")
Replace separate receive-dot/receive-address spans with a single receive-address-block element
Address is still shown in full (no truncation) as appropriate for the receive view
The receive view was using raw `textContent` and a manually constructed color dot instead of the shared `formatAddressHtml` helper used by other views. This violated the display consistency policy ("Same data formatted identically across all screens").
## Changes
- Use `formatAddressHtml()` to render address with color dot, title (e.g. "Wallet 1 — Address 1"), and ENS name — matching `addressDetail`
- Make the address block itself click-to-copy (matching policy: "Clicking any address copies the full untruncated value")
- Replace separate `receive-dot`/`receive-address` spans with a single `receive-address-block` element
- Address is still shown in full (no truncation) as appropriate for the receive view
`docker build .` passes.
Closes #58
The receive view was using raw textContent and a manually constructed
color dot instead of the shared formatAddressHtml helper used by other
views. This violated the display consistency policy ('Same data
formatted identically across all screens').
Changes:
- Use formatAddressHtml() to render address with color dot, title
(e.g. 'Wallet 1 — Address 1'), and ENS name — matching addressDetail
- Make the address block itself click-to-copy (matching policy:
'Clicking any address copies the full untruncated value')
- Replace separate receive-dot/receive-address spans with a single
receive-address-block element
- Address is still shown in full (no truncation) as appropriate for
the receive view
Closes#58
## Review: ✅ Approved
**Build:** `docker build .` passes.
**Changes reviewed:**
- Correctly replaces manual dot/address rendering with shared `formatAddressHtml()` + `addressTitle()` helpers
- Address block is now click-to-copy using `dataset.full`, matching the display consistency policy
- Existing copy button updated to use the same `dataset.full` source
- HTML simplified: two spans → one `receive-address-block`
- No linter/config/test changes
- No security concerns
This properly fixes #58. Ready to merge.
sneak
merged commit e8ede7010a into main2026-02-28 20:57:08 +01:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
The receive view was using raw
textContentand a manually constructed color dot instead of the sharedformatAddressHtmlhelper used by other views. This violated the display consistency policy ("Same data formatted identically across all screens").Changes
formatAddressHtml()to render address with color dot, title (e.g. "Wallet 1 — Address 1"), and ENS name — matchingaddressDetailreceive-dot/receive-addressspans with a singlereceive-address-blockelementdocker build .passes.Closes #58
The receive view was using raw textContent and a manually constructed color dot instead of the shared formatAddressHtml helper used by other views. This violated the display consistency policy ('Same data formatted identically across all screens'). Changes: - Use formatAddressHtml() to render address with color dot, title (e.g. 'Wallet 1 — Address 1'), and ENS name — matching addressDetail - Make the address block itself click-to-copy (matching policy: 'Clicking any address copies the full untruncated value') - Replace separate receive-dot/receive-address spans with a single receive-address-block element - Address is still shown in full (no truncation) as appropriate for the receive view Closes #58Review: ✅ Approved
Build:
docker build .passes.Changes reviewed:
formatAddressHtml()+addressTitle()helpersdataset.full, matching the display consistency policydataset.fullsourcereceive-address-blockThis properly fixes #58. Ready to merge.