fix: use formatAddressHtml in receive view for display consistency #69

Merged
sneak merged 1 commits from fix/issue-58-receive-address-consistency into main 2026-02-28 20:57:08 +01:00
Collaborator

The receive view was using raw textContent and a manually constructed color dot instead of the shared formatAddressHtml helper used by other views. This violated the display consistency policy ("Same data formatted identically across all screens").

Changes

  • Use formatAddressHtml() to render address with color dot, title (e.g. "Wallet 1 — Address 1"), and ENS name — matching addressDetail
  • Make the address block itself click-to-copy (matching policy: "Clicking any address copies the full untruncated value")
  • Replace separate receive-dot/receive-address spans with a single receive-address-block element
  • Address is still shown in full (no truncation) as appropriate for the receive view

docker build . passes.

Closes #58

The receive view was using raw `textContent` and a manually constructed color dot instead of the shared `formatAddressHtml` helper used by other views. This violated the display consistency policy ("Same data formatted identically across all screens"). ## Changes - Use `formatAddressHtml()` to render address with color dot, title (e.g. "Wallet 1 — Address 1"), and ENS name — matching `addressDetail` - Make the address block itself click-to-copy (matching policy: "Clicking any address copies the full untruncated value") - Replace separate `receive-dot`/`receive-address` spans with a single `receive-address-block` element - Address is still shown in full (no truncation) as appropriate for the receive view `docker build .` passes. Closes #58
clawbot added 1 commit 2026-02-28 20:47:56 +01:00
fix: use formatAddressHtml in receive view for display consistency
All checks were successful
check / check (push) Successful in 22s
a2fbb0e30d
The receive view was using raw textContent and a manually constructed
color dot instead of the shared formatAddressHtml helper used by other
views. This violated the display consistency policy ('Same data
formatted identically across all screens').

Changes:
- Use formatAddressHtml() to render address with color dot, title
  (e.g. 'Wallet 1 — Address 1'), and ENS name — matching addressDetail
- Make the address block itself click-to-copy (matching policy:
  'Clicking any address copies the full untruncated value')
- Replace separate receive-dot/receive-address spans with a single
  receive-address-block element
- Address is still shown in full (no truncation) as appropriate for
  the receive view

Closes #58
clawbot added the needs-review label 2026-02-28 20:48:04 +01:00
clawbot added merge-ready and removed needs-review labels 2026-02-28 20:56:29 +01:00
sneak was assigned by clawbot 2026-02-28 20:56:30 +01:00
Author
Collaborator

Review: Approved

Build: docker build . passes.

Changes reviewed:

  • Correctly replaces manual dot/address rendering with shared formatAddressHtml() + addressTitle() helpers
  • Address block is now click-to-copy using dataset.full, matching the display consistency policy
  • Existing copy button updated to use the same dataset.full source
  • HTML simplified: two spans → one receive-address-block
  • No linter/config/test changes
  • No security concerns

This properly fixes #58. Ready to merge.

## Review: ✅ Approved **Build:** `docker build .` passes. **Changes reviewed:** - Correctly replaces manual dot/address rendering with shared `formatAddressHtml()` + `addressTitle()` helpers - Address block is now click-to-copy using `dataset.full`, matching the display consistency policy - Existing copy button updated to use the same `dataset.full` source - HTML simplified: two spans → one `receive-address-block` - No linter/config/test changes - No security concerns This properly fixes #58. Ready to merge.
sneak merged commit e8ede7010a into main 2026-02-28 20:57:08 +01:00
sneak deleted branch fix/issue-58-receive-address-consistency 2026-02-28 20:57:09 +01:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/AutistMask#69