fix: the recipient warning says what it checked and skips addresses that have received ETH (closes #528)
The transaction count the node reports is what an address has sent, so an address that only receives, such as a savings address, got the "ZERO transaction history" box on every send. The check now also asks the node for the recipient's balance and warns only when both are zero. The box says the address has never sent a transaction and holds no ETH, naming the active network's native token as the contract warning does. Model: opus-5-5
This commit was merged in pull request #571.
This commit is contained in:
@@ -1020,7 +1020,7 @@ on the approval screen, the amount on the wait, success and error screens, the
|
||||
transaction history and the transaction detail screen, and the refusal of a fee
|
||||
above 1 ETH. A chain id that names no network reads `ETH`. Wherever this
|
||||
document shows ETH as the label of a native balance, value or fee, in a "Native
|
||||
ETH transfer" type line, in the contract-recipient warning or in that refusal,
|
||||
ETH transfer" type line, in the two recipient warnings or in that refusal,
|
||||
Sepolia shows `SepoliaETH`. The swap lines keep `ETH`, the router's own name for
|
||||
the native currency, and the ETH/USD price line, shown on mainnet only, keeps
|
||||
its fixed wording.
|
||||
@@ -1730,8 +1730,10 @@ view would leave a wallet one click from deletion.
|
||||
reserved either way
|
||||
- Warnings: inline warnings from the local checks (scam address, self-send)
|
||||
plus four reserved warning boxes made visible by the async checks —
|
||||
recipient with no transaction history, recipient is a contract, burn
|
||||
address, and an Etherscan phishing/scam label
|
||||
recipient that has never sent a transaction and holds no ETH, recipient is
|
||||
a contract, burn address, and an Etherscan phishing/scam label. An address
|
||||
that has received ETH but never sent a transaction still holds that ETH,
|
||||
so it gets no warning
|
||||
- Errors (insufficient balance), plus three reserved error boxes — the
|
||||
amount plus the fee exceeds the balance (ETH transfers), not enough ETH to
|
||||
pay the fee for the transfer (ERC-20 transfers), and the fee could not be
|
||||
|
||||
Reference in New Issue
Block a user