fix: history calls an execute or multicall a Swap only when sent to a router (closes #580)
The history labelled any call named execute or multicall a Swap, whatever contract it went to, so a multisig or smart account call showed as a Swap in the list and on TransactionDetail's Type line. Such a call is now a Swap only when sent to a Universal Router address listed for the network the transaction is on, the list the approval screen uses (routerRelease(), now exported from uniswap.js). Any other is labelled by its method name and its Type line reads Contract Call. The named router swap methods keep their label. Model: opus-5-5
This commit was merged in pull request #643.
This commit is contained in:
@@ -1999,7 +1999,11 @@ view would leave a wallet one click from deletion.
|
||||
- Type: transaction classification — one of: Native ETH Transfer, ERC-20
|
||||
Token Transfer, Swap, Token Approval, Contract Call, Contract Creation. A
|
||||
transfer with a token contract is an ERC-20 Token Transfer whatever symbol
|
||||
the token reports.
|
||||
the token reports. A call named `execute` or `multicall` is a Swap, here
|
||||
and on its history row, only when it was sent to one of the Universal
|
||||
Router addresses Uniswap publishes for the network it was sent on (see
|
||||
Transaction Decoding); sent to any other contract, its history row shows
|
||||
the method name and this line reads Contract Call.
|
||||
- Status: "Success" or "Failed"
|
||||
- From: blockie + color dot + full address (tap to copy) + etherscan link;
|
||||
ENS name if available
|
||||
|
||||
Reference in New Issue
Block a user