Teal Dulcet
ec497efa69
Quote echo commands to preserve whitespace.
2024-04-03 09:22:50 -04:00
Teal Dulcet
55a8be4aa9
Removed unnecessary bc commands.
2024-04-03 09:22:50 -04:00
Teal Dulcet
3399b25084
Replaced the pwd command with Bash's $PWD variable.
2024-04-03 09:22:50 -04:00
Teal Dulcet
2afd0451c1
Fixed SC2007: Use $((..)) instead of deprecated $[..].
2024-04-03 09:22:50 -04:00
Teal Dulcet
27cf11d8ec
Fixed SC2005: Useless echo.
2024-04-03 09:22:50 -04:00
Teal Dulcet
44d9f6eebd
Fixed SC2236: Use -n instead of ! -z.
2024-04-03 09:22:50 -04:00
Teal Dulcet
4b7d4ba0a6
Fixed SC2166: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
2024-04-03 09:22:50 -04:00
Teal Dulcet
67bcaea71e
Fixed SC2091: Remove surrounding $() to avoid executing output.
2024-04-03 09:22:50 -04:00
Teal Dulcet
bdf4155bed
Fixed SC2046: Quote to prevent word splitting.
2024-04-03 09:21:34 -04:00
Teal Dulcet
f1888f2043
Fixed SC2148: Add a shebang.
2024-04-03 09:21:34 -04:00
Teal Dulcet
33559bb844
Fixed SC2164: Use 'cd ... || exit' in case cd fails.
2024-04-03 09:21:34 -04:00
Teal Dulcet
30c4681e80
Fixed SC2086: Double quote to prevent globbing and word splitting.
2024-04-03 09:20:20 -04:00
Teal Dulcet
133bae1300
Fixed SC2006: Use $(...) notation instead of legacy backticks `...`.
2024-04-03 05:17:25 -07:00
Joshua Tauberer
830c83daa1
v68
2024-04-01 10:55:52 -04:00
Joshua Tauberer
7382c18e8f
CHANGELOG entries
2024-04-01 10:54:21 -04:00
Joshua Tauberer
fa72e015ee
Update SMTP Smuggling protection to the 'long-term fix'
...
* Revert "Guard against SMTP smuggling", commit faf23f150c
, by restoring the setting to its default.
* Revert "[security] SMTP smuggling: update short term fix (#2346 )", commmit e931e103fe
, by restoring the setting to its default.
* Set smtpd_forbid_bare_newline=normalize.
2024-03-23 13:15:32 -04:00
KiekerJan
1a239c55bb
More robust reading of sshd configuration ( #2330 )
...
Use sshd -T instead of directly reading the configuration files
2024-03-23 11:16:40 -04:00
Gio
9b450469eb
Mail guide: OS X -> macOS ( #2306 )
2024-03-23 09:04:43 -04:00
jvolkenant
163b1a297e
Silence "wal" output on setup using hide_output ( #2368 )
2024-03-23 08:49:24 -04:00
Joshua Tauberer
18b8f9ab4b
Revert "Allow customizations to Roundcube settings to persist between updates by including a configuration override file, if it exists ( #2333 )"
...
This reverts commit 1b8cdeb644
.
It didn't execute. I should have tried it first.
2024-03-10 08:25:34 -04:00
KiekerJan
0b1d92388a
Take spamhaus return codes into account in status check and postfix config ( #2332 )
2024-03-10 08:09:36 -04:00
Crag-Monkey
1b8cdeb644
Allow customizations to Roundcube settings to persist between updates by including a configuration override file, if it exists ( #2333 )
2024-03-10 08:02:16 -04:00
Bastian Bittorf
1053340124
setup/preflight.sh: fix some minor shellcheck complaints ( #2342 )
...
This file passes shellcheck now without errors.
This paritally fixes #1457 - the former errors where:
$ shellcheck setup/preflight.sh
In setup/preflight.sh line 1:
^-- SC2148 (error): Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
In setup/preflight.sh line 29:
if [ $TOTAL_PHYSICAL_MEM -lt 490000 ]; then
^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ "$TOTAL_PHYSICAL_MEM" -lt 490000 ]; then
In setup/preflight.sh line 31:
TOTAL_PHYSICAL_MEM=$(expr \( \( $TOTAL_PHYSICAL_MEM \* 1024 \) / 1000 \) / 1000)
^--^ SC2003 (style): expr is antiquated. Consider rewriting this using $((..)), ${} or [[ ]].
^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
TOTAL_PHYSICAL_MEM=$(expr \( \( "$TOTAL_PHYSICAL_MEM" \* 1024 \) / 1000 \) / 1000)
In setup/preflight.sh line 38:
if [ $TOTAL_PHYSICAL_MEM -lt 750000 ]; then
^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ "$TOTAL_PHYSICAL_MEM" -lt 750000 ]; then
For more information:
https://www.shellcheck.net/wiki/SC2148 -- Tips depend on target shell and y...
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
https://www.shellcheck.net/wiki/SC2003 -- expr is antiquated. Consider rewr...
2024-03-10 08:01:13 -04:00
Joshua Tauberer
315d2cf691
Fixed errors found by the Ruff Python linter ( #2343 )
2024-03-10 07:57:19 -04:00
Teal Dulcet
dbc2b5eee0
Fixed ISC003 (explicit-string-concatenation): Explicitly concatenated string should be implicitly concatenated
2024-03-10 07:56:49 -04:00
Teal Dulcet
775a4223de
Fixed F821 (undefined-name): Undefined name `e`
2024-03-10 07:56:49 -04:00
Teal Dulcet
618c466b84
Fixed SIM114 (if-with-same-arms): Combine `if` branches using logical `or` operator
2024-03-10 07:56:49 -04:00
Teal Dulcet
a32354fd91
Fixed PLR5501 (collapsible-else-if): Use `elif` instead of `else` then `if`, to reduce indentation
2024-03-10 07:56:49 -04:00
Teal Dulcet
1d79f9bb2b
Fixed PERF401 (manual-list-comprehension): Use a list comprehension to create a transformed list
2024-03-10 07:56:49 -04:00
Teal Dulcet
cacf6d2006
Fixed E721 (type-comparison): Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
2024-03-10 07:56:49 -04:00
Teal Dulcet
f0377dd59e
Fixed SIM105 (suppressible-exception)
2024-03-10 07:56:49 -04:00
Teal Dulcet
6a47133e3f
Fixed F811 (redefined-while-unused): Redefinition of unused `sys` from line 10
2024-03-10 07:56:49 -04:00
Teal Dulcet
7f456d8e8b
Fixed ISC002 (multi-line-implicit-string-concatenation): Implicitly concatenated string literals over multiple lines
2024-03-10 07:56:49 -04:00
Teal Dulcet
e466b9bb53
Fixed RUF005 (collection-literal-concatenation)
2024-03-10 07:56:49 -04:00
Teal Dulcet
0e9193651d
Fixed PLW1514 (unspecified-encoding): `open` in text mode without explicit `encoding` argument
2024-03-10 07:56:49 -04:00
Teal Dulcet
a02b59d4e4
Fixed F401 (unused-import): `socket.timeout` imported but unused
2024-03-10 07:56:49 -04:00
Teal Dulcet
15bddcbc39
Fixed RUF010 (explicit-f-string-type-conversion): Use explicit conversion flag
2024-03-10 07:56:49 -04:00
Teal Dulcet
c719fce40a
Fixed UP032 (f-string): Use f-string instead of `format` call
2024-03-10 07:56:49 -04:00
Teal Dulcet
3111cf56de
Fixed EM102 (f-string-in-exception): Exception must not use an f-string literal, assign to variable first
2024-03-10 07:56:49 -04:00
Teal Dulcet
6508d47da1
Fixed C405 (unnecessary-literal-set): Unnecessary `list` literal (rewrite as a `set` literal)
2024-03-10 07:56:49 -04:00
Teal Dulcet
9b961b7ba0
Fixed UP024 (os-error-alias): Replace aliased errors with `OSError`
2024-03-10 07:56:49 -04:00
Teal Dulcet
b13cef9b1d
Fixed PIE790 (unnecessary-placeholder): Unnecessary `pass` statement
2024-03-10 07:56:49 -04:00
Teal Dulcet
8b9d3ec094
Fixed W292 (missing-newline-at-end-of-file): No newline at end of file
2024-03-10 07:56:49 -04:00
Teal Dulcet
d1d3d08d70
Fixed B006 (mutable-argument-default): Do not use mutable data structures for argument defaults
2024-03-10 07:56:49 -04:00
Teal Dulcet
922c59ddaf
Fixed SIM212 (if-expr-with-twisted-arms): Use `with_lines if with_lines else []` instead of `[] if not with_lines else with_lines`
2024-03-10 07:56:49 -04:00
Teal Dulcet
20a99c0ab8
Fixed UP041 (timeout-error-alias): Replace aliased errors with `TimeoutError`
2024-03-10 07:56:49 -04:00
Teal Dulcet
54af4725f9
Fixed C404 (unnecessary-list-comprehension-dict): Unnecessary `list` comprehension (rewrite as a `dict` comprehension)
2024-03-10 07:56:49 -04:00
Teal Dulcet
fd4fcdaf53
Fixed E712 (true-false-comparison): Comparison to `False` should be `cond is False` or `if not cond:`
2024-03-10 07:56:49 -04:00
Teal Dulcet
d661d623dc
Fixed RUF017 (quadratic-list-summation): Avoid quadratic list summation
2024-03-10 07:56:49 -04:00
Teal Dulcet
f621789298
Fixed SIM118 (in-dict-keys): Use `key in dict` instead of `key in dict.keys()`
2024-03-10 07:56:49 -04:00