Commit Graph
5 Commits
Author SHA1 Message Date
captainwasabi 9ee7bbf78a Merge branch 'master' into patch-2 2019-08-12 12:24:02 -04:00
captainwasabi 6ecf713e4f Merge pull request #1 from captainwasabi/patch-1
add proper check for DNS error in list_target_files
2019-08-12 12:21:11 -04:00
captainwasabi a277d4bcc7 Write rsync settings before validating
I understand the philosophy behind not saving until validated, but there are many examples in software where this is not true.  For instance, setting up a mail account in Thunderbird or outlook.  You can use the wrong settings on initial setup (indeed, outlook forces you to in some circumstances) then go repair them later.  This also solves the second issue I raised in mail-in-a-box#1624 because running backup.py --validate will try to use the new settings, just like the Unkown Error case error message implies it should.
2019-08-12 06:07:57 -04:00
captainwasabi f773003119 Save rsync settings before validating
I understand the philosophy behind not saving until validated, but there are many examples in software where this is not true.  For instance, setting up a mail account in Thunderbird or outlook.  You can use the wrong settings on initial setup (indeed, outlook forces you to in some circumstances) then go repair them later.  This also solves the second issue I raised in #1624 because running backup.py --validate will try to use the new settings, just like the Unkown Error case error message implies it should.
2019-08-12 06:02:13 -04:00
captainwasabi 3f72f23e81 add proper check for DNS error in list_target_files
The elif needed to check to see if the string was in the listing of results of the shell command.  As it was the conditional was just the string which always evaluates to true and was therefore giving a misleading error message.
2019-08-11 16:49:35 -04:00