downtownallday
95f23961dc
QA: wait for first run wizard to display
2024-04-03 12:47:23 -04:00
downtownallday
dbc7d87f4b
Actions: update checkout to v4 and remove duplicate test suite
2024-04-03 12:47:00 -04:00
downtownallday
03e70941f5
QA: redirect command output to test output file
2024-04-03 12:46:05 -04:00
downtownallday
11e69f53a0
Merge remote-tracking branch 'upstream/main' into merge-upstream
...
# Conflicts:
# setup/firstuser.sh
# setup/functions.sh
# setup/mail-users.sh
# setup/management.sh
# setup/network-checks.sh
# setup/nextcloud.sh
# setup/questions.sh
# setup/ssl.sh
# setup/start.sh
# setup/system.sh
# setup/webmail.sh
# tools/archive_conf_files.sh
# tools/web_update
2024-04-03 12:45:10 -04:00
Joshua Tauberer
a332be6a7b
Fixed bugs found by the ShellCheck linter ( #1457 )
2024-04-03 09:25:32 -04:00
Teal Dulcet
c7faccf1fa
Fixed SC2244: Prefer explicit -n to check non-empty string.
2024-04-03 09:22:50 -04:00
Teal Dulcet
ec497efa69
Quote echo commands to preserve whitespace.
2024-04-03 09:22:50 -04:00
Teal Dulcet
55a8be4aa9
Removed unnecessary bc commands.
2024-04-03 09:22:50 -04:00
Teal Dulcet
3399b25084
Replaced the pwd command with Bash's $PWD variable.
2024-04-03 09:22:50 -04:00
Teal Dulcet
2afd0451c1
Fixed SC2007: Use $((..)) instead of deprecated $[..].
2024-04-03 09:22:50 -04:00
Teal Dulcet
27cf11d8ec
Fixed SC2005: Useless echo.
2024-04-03 09:22:50 -04:00
Teal Dulcet
44d9f6eebd
Fixed SC2236: Use -n instead of ! -z.
2024-04-03 09:22:50 -04:00
Teal Dulcet
4b7d4ba0a6
Fixed SC2166: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
2024-04-03 09:22:50 -04:00
Teal Dulcet
67bcaea71e
Fixed SC2091: Remove surrounding $() to avoid executing output.
2024-04-03 09:22:50 -04:00
Teal Dulcet
bdf4155bed
Fixed SC2046: Quote to prevent word splitting.
2024-04-03 09:21:34 -04:00
Teal Dulcet
f1888f2043
Fixed SC2148: Add a shebang.
2024-04-03 09:21:34 -04:00
Teal Dulcet
33559bb844
Fixed SC2164: Use 'cd ... || exit' in case cd fails.
2024-04-03 09:21:34 -04:00
Teal Dulcet
30c4681e80
Fixed SC2086: Double quote to prevent globbing and word splitting.
2024-04-03 09:20:20 -04:00
Teal Dulcet
133bae1300
Fixed SC2006: Use $(...) notation instead of legacy backticks ...
.
2024-04-03 05:17:25 -07:00
downtownallday
21b01aab6d
v68
2024-04-01 17:59:40 -04:00
downtownallday
1be8257b20
Merge branch 'main' of https://github.com/mail-in-a-box/mailinabox
...
# Conflicts:
# CHANGELOG.md
# README.md
2024-04-01 17:57:03 -04:00
Joshua Tauberer
830c83daa1
v68
2024-04-01 10:55:52 -04:00
Joshua Tauberer
7382c18e8f
CHANGELOG entries
2024-04-01 10:54:21 -04:00
Downtown Allday
379fd9a25b
Merge pull request #30 from downtownallday/merge-upstream
...
Merge upstream
2024-03-23 18:11:45 -04:00
downtownallday
6ade958e2d
Merge remote-tracking branch 'upstream/main' into merge-upstream
2024-03-23 17:50:34 -04:00
downtownallday
7e03b651d7
Merge remote-tracking branch 'upstream/main' into merge-upstream
...
# Conflicts:
# management/status_checks.py
2024-03-23 17:48:50 -04:00
Joshua Tauberer
14d0e20eab
CHANGELOG entries
2024-03-23 13:18:16 -04:00
Joshua Tauberer
fa72e015ee
Update SMTP Smuggling protection to the 'long-term fix'
...
* Revert "Guard against SMTP smuggling", commit faf23f150c
, by restoring the setting to its default.
* Revert "[security] SMTP smuggling: update short term fix (#2346 )", commmit e931e103fe
, by restoring the setting to its default.
* Set smtpd_forbid_bare_newline=normalize.
2024-03-23 13:15:32 -04:00
KiekerJan
1a239c55bb
More robust reading of sshd configuration ( #2330 )
...
Use sshd -T instead of directly reading the configuration files
2024-03-23 11:16:40 -04:00
Downtown Allday
a219d6fd67
Merge pull request #29 from downtownallday/merge-upstream
...
Merge upstream
2024-03-23 10:55:33 -04:00
downtownallday
4be2d1b844
Merge remote-tracking branch 'upstream/main' into merge-upstream
...
# Conflicts:
# setup/webmail.sh
2024-03-23 10:32:25 -04:00
Gio
9b450469eb
Mail guide: OS X -> macOS ( #2306 )
2024-03-23 09:04:43 -04:00
jvolkenant
163b1a297e
Silence "wal" output on setup using hide_output ( #2368 )
2024-03-23 08:49:24 -04:00
downtownallday
88558f81e3
Return the result, not None to avoid crashing the management daemon
2024-03-12 10:22:49 -04:00
Downtown Allday
5e24d22dba
Merge pull request #28 from downtownallday/merge-upstream
...
Merge upstream
2024-03-12 08:02:48 -04:00
downtownallday
d349150dd0
Merge remote-tracking branch 'upstream/main' into merge-upstream
...
# Conflicts:
# .gitignore
# management/auth.py
# management/daemon.py
# management/mail_log.py
# management/mailconfig.py
# management/mfa.py
# management/ssl_certificates.py
# management/status_checks.py
# management/utils.py
# management/web_update.py
# setup/mail-postfix.sh
# setup/migrate.py
# setup/preflight.sh
# setup/webmail.sh
# tests/test_mail.py
# tools/editconf.py
2024-03-12 07:41:14 -04:00
Joshua Tauberer
18b8f9ab4b
Revert "Allow customizations to Roundcube settings to persist between updates by including a configuration override file, if it exists ( #2333 )"
...
This reverts commit 1b8cdeb644
.
It didn't execute. I should have tried it first.
2024-03-10 08:25:34 -04:00
KiekerJan
0b1d92388a
Take spamhaus return codes into account in status check and postfix config ( #2332 )
2024-03-10 08:09:36 -04:00
Crag-Monkey
1b8cdeb644
Allow customizations to Roundcube settings to persist between updates by including a configuration override file, if it exists ( #2333 )
2024-03-10 08:02:16 -04:00
Bastian Bittorf
1053340124
setup/preflight.sh: fix some minor shellcheck complaints ( #2342 )
...
This file passes shellcheck now without errors.
This paritally fixes #1457 - the former errors where:
$ shellcheck setup/preflight.sh
In setup/preflight.sh line 1:
^-- SC2148 (error): Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
In setup/preflight.sh line 29:
if [ $TOTAL_PHYSICAL_MEM -lt 490000 ]; then
^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ "$TOTAL_PHYSICAL_MEM" -lt 490000 ]; then
In setup/preflight.sh line 31:
TOTAL_PHYSICAL_MEM=$(expr \( \( $TOTAL_PHYSICAL_MEM \* 1024 \) / 1000 \) / 1000)
^--^ SC2003 (style): expr is antiquated. Consider rewriting this using $((..)), ${} or [[ ]].
^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
TOTAL_PHYSICAL_MEM=$(expr \( \( "$TOTAL_PHYSICAL_MEM" \* 1024 \) / 1000 \) / 1000)
In setup/preflight.sh line 38:
if [ $TOTAL_PHYSICAL_MEM -lt 750000 ]; then
^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ "$TOTAL_PHYSICAL_MEM" -lt 750000 ]; then
For more information:
https://www.shellcheck.net/wiki/SC2148 -- Tips depend on target shell and y...
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
https://www.shellcheck.net/wiki/SC2003 -- expr is antiquated. Consider rewr...
2024-03-10 08:01:13 -04:00
Joshua Tauberer
315d2cf691
Fixed errors found by the Ruff Python linter ( #2343 )
2024-03-10 07:57:19 -04:00
Teal Dulcet
dbc2b5eee0
Fixed ISC003 (explicit-string-concatenation): Explicitly concatenated string should be implicitly concatenated
2024-03-10 07:56:49 -04:00
Teal Dulcet
775a4223de
Fixed F821 (undefined-name): Undefined name e
2024-03-10 07:56:49 -04:00
Teal Dulcet
618c466b84
Fixed SIM114 (if-with-same-arms): Combine if
branches using logical or
operator
2024-03-10 07:56:49 -04:00
Teal Dulcet
a32354fd91
Fixed PLR5501 (collapsible-else-if): Use elif
instead of else
then if
, to reduce indentation
2024-03-10 07:56:49 -04:00
Teal Dulcet
1d79f9bb2b
Fixed PERF401 (manual-list-comprehension): Use a list comprehension to create a transformed list
2024-03-10 07:56:49 -04:00
Teal Dulcet
cacf6d2006
Fixed E721 (type-comparison): Use is
and is not
for type comparisons, or isinstance()
for isinstance checks
2024-03-10 07:56:49 -04:00
Teal Dulcet
f0377dd59e
Fixed SIM105 (suppressible-exception)
2024-03-10 07:56:49 -04:00
Teal Dulcet
6a47133e3f
Fixed F811 (redefined-while-unused): Redefinition of unused sys
from line 10
2024-03-10 07:56:49 -04:00
Teal Dulcet
7f456d8e8b
Fixed ISC002 (multi-line-implicit-string-concatenation): Implicitly concatenated string literals over multiple lines
2024-03-10 07:56:49 -04:00