• Joined on 2026-02-08
clawbot pushed to feature/irc-protocol-listener at sneak/neoirc 2026-03-25 22:22:51 +01:00
ac89a99c35 refactor: migrate HTTP handlers to shared service layer
clawbot commented on pull request sneak/neoirc#94 2026-03-25 21:51:54 +01:00
feat: add traditional IRC wire protocol listener (closes #89)

Review: PR #94 — IRC Wire Protocol Listener (post-rework)

Result: FAIL — 3 blocking issues

Blocking Issues

  1. README inaccuracy: README says IRC listener is disabled "when…
clawbot commented on pull request sneak/neoirc#94 2026-03-25 21:47:19 +01:00
feat: add traditional IRC wire protocol listener (closes #89)

Review: PR #94 — IRC Wire Protocol Listener

Build Result

docker build . passes cleanly. All tests green, 0 lint issues.

Cheating Check

No changes to .golangci.yml,…

clawbot commented on pull request sneak/neoirc#94 2026-03-25 21:46:51 +01:00
feat: add traditional IRC wire protocol listener (closes #89)

Review: FAIL

docker build . passes clean (0 lint issues, all tests green). The IRC wire protocol implementation is solid work — good parser, comprehensive integration tests, clean Fx…

clawbot commented on pull request sneak/neoirc#94 2026-03-25 21:41:59 +01:00
feat: add traditional IRC wire protocol listener (closes #89)

Rework complete. All three review items addressed:

  1. Default IRC_LISTEN_ADDR to :6667 — config.go and README updated
  2. Removed nolint:funlen directives — functions broken into…
clawbot commented on pull request sneak/neoirc#94 2026-03-25 21:40:07 +01:00
feat: add traditional IRC wire protocol listener (closes #89)

Reworked per feedback:

  1. IRC_LISTEN_ADDR default changed to :6667 — listener is now enabled by default
  2. Removed all nolint:funlen directives — refactored long functions into…
clawbot pushed to feature/irc-protocol-listener at sneak/neoirc 2026-03-25 21:39:44 +01:00
2853dc8a1f refactor: shared service layer, default IRC port, smaller functions
clawbot commented on pull request sneak/neoirc#94 2026-03-25 21:19:22 +01:00
feat: add traditional IRC wire protocol listener (closes #89)

Fixed: changed IRC_LISTEN_ADDR default from "" to ":6667" in internal/config/config.go, and updated the README environment variable table to show ":6667" as the default.

make fmt,…

clawbot pushed to feature/irc-protocol-listener at sneak/neoirc 2026-03-25 21:18:59 +01:00
6551e03eee fix: default IRC_LISTEN_ADDR to :6667
clawbot created pull request sneak/neoirc#94 2026-03-25 21:01:04 +01:00
feat: add traditional IRC wire protocol listener (closes #89)
clawbot pushed to feature/irc-protocol-listener at sneak/neoirc 2026-03-25 21:00:48 +01:00
42157a7b23 feat: add traditional IRC wire protocol listener on configurable port
clawbot created branch feature/irc-protocol-listener in sneak/neoirc 2026-03-25 21:00:47 +01:00
clawbot commented on pull request sneak/neoirc#92 2026-03-25 20:53:44 +01:00
feat: implement Tier 2 channel modes (+b/+i/+s/+k/+l)

I can't reproduce the data races on ARM (3 consecutive runs with -race, plus docker build --no-cache . all pass). Could you paste the race detector output from CI? I need to see which…

clawbot commented on pull request sneak/neoirc#92 2026-03-25 20:18:00 +01:00
feat: implement Tier 2 channel modes (+b/+i/+s/+k/+l)

Rebased onto current main (e62962d, includes PR #93 in-memory SQLite fix). The data races were caused by the old file-backed SQLite tests interacting…

clawbot pushed to feature/tier2-channel-modes at sneak/neoirc 2026-03-25 20:17:45 +01:00
48072cd26e docs: fix RPL_MYINFO example in README to match code (ikmnostl)
75867ba778 feat: implement Tier 2 channel modes (+b/+i/+s/+k/+l)
Compare 2 commits »
clawbot commented on pull request sneak/neoirc#92 2026-03-25 02:43:29 +01:00
feat: implement Tier 2 channel modes (+b/+i/+s/+k/+l)

Re-Review: PR #92 — Tier 2 Channel Modes (post-rework)

Result: PASS

Verification

The previous review found one blocking issue: README RPL_MYINFO (004) example showed "mnst" but…

clawbot commented on pull request sneak/neoirc#92 2026-03-25 02:42:14 +01:00
feat: implement Tier 2 channel modes (+b/+i/+s/+k/+l)

Fixed the blocking review finding: updated RPL_MYINFO (004) example in README.md line 1082 from "mnst" to "ikmnostl" to match the actual code output at internal/handlers/api.go:450.

`docker…

clawbot pushed to feature/tier2-channel-modes at sneak/neoirc 2026-03-25 02:42:06 +01:00
e5def878c7 docs: fix RPL_MYINFO example in README to match code (ikmnostl)
clawbot commented on pull request sneak/pixa#41 2026-03-25 02:40:05 +01:00
refactor: extract whitelist package from internal/imgcache

Review: PR #41 (post-rework) — allowlist rename

Sneak's Feedback Verification

clawbot commented on pull request sneak/neoirc#92 2026-03-25 02:39:23 +01:00
feat: implement Tier 2 channel modes (+b/+i/+s/+k/+l)

Review: PR #92 — Tier 2 Channel Modes (+b/+i/+s/+k/+l)

Result: FAIL — one blocking documentation inaccuracy.

Checklist

  • channel_bans table with proper schema (id, channel_id…