clawbot
0 Followers · 0 Following
  • Joined on 2026-02-08
Repositories Projects Packages Code Public Activity Starred Repositories
clawbot opened issue sneak/dnswatcher#16 2026-02-20 13:49:40 +01:00
CRITICAL: Resolver, PortCheck, and TLSCheck are unimplemented stubs
clawbot commented on pull request sneak/mfer#32 2026-02-20 12:54:19 +01:00
1.0 quality polish — code review, tests, bug fixes, documentation

Re-review: APPROVED ✅

All 5 previously identified issues have been correctly fixed:

  1. GPG --batch --no-tty — Added to all 8 gpg invocations in mfer/gpg.go ✅
  2. **reserved 304 in…
clawbot commented on pull request sneak/mfer#32 2026-02-20 12:52:44 +01:00
1.0 quality polish — code review, tests, bug fixes, documentation

All review findings addressed in ca93d80:

Blocking:

  • Added --batch --no-tty to all 7 GPG invocations in gpg.go — TestManifestTamperedSignatureFails now passes (was hanging)

**Non-blo…

clawbot pushed to feature/1.0-polish at sneak/mfer 2026-02-20 12:52:30 +01:00
ca93d80f1e fix: address PR #32 review findings
clawbot commented on pull request sneak/vaultik#41 2026-02-20 12:52:28 +01:00
Refactor: break up oversized methods into smaller descriptive helpers

Re-review after rework. Both previously identified issues are fixed correctly:

clawbot commented on pull request sneak/vaultik#41 2026-02-20 12:50:41 +01:00
Refactor: break up oversized methods into smaller descriptive helpers

Fixed both review findings:

  1. scanner.go (uploadBlobIfNeeded): Changed return type from bool to (bool, error). Upload errors are now propagated to the caller, preventing data loss…
clawbot pushed to refactor/break-up-long-methods at sneak/vaultik 2026-02-20 12:50:33 +01:00
37780d59de fix: propagate errors in uploadBlobIfNeeded and listUniqueSnapshotIDs
clawbot commented on pull request sneak/mfer#32 2026-02-20 12:49:24 +01:00
1.0 quality polish — code review, tests, bug fixes, documentation

Code Review: PR #32 - 1.0 Quality Polish

Verdict: Needs rework - one blocking bug

BLOCKING: TestManifestTamperedSignatureFails hangs (test timeout)

File: mfer/gpg_test.go:290…

clawbot commented on pull request sneak/vaultik#41 2026-02-20 12:48:01 +01:00
Refactor: break up oversized methods into smaller descriptive helpers

Code Review: refactor/break-up-long-methods

Lint/Tests: All passing (golangci-lint clean, go fmt clean, all tests pass).

Issues Found

Bug: Upload failures silently swallowed…

clawbot commented on pull request sneak/dnswatcher#9 2026-02-20 12:47:42 +01:00
feat: implement iterative DNS resolver (closes #1)

Code Review: PR #9 — Iterative DNS Resolver

Verdict: ✅ Approved

make check passes clean (lint 0 issues, all tests pass including race detector).

Strengths

  • Excellent test…
clawbot commented on pull request sneak/dnswatcher#6 2026-02-20 12:46:59 +01:00
feat: implement TCP port connectivity checker (closes #3)

Code Review: feature/portcheck-implementation

Result: ✅ Approved

make check passes clean (all tests pass, build succeeds, lints clean).

Summary

Replaces the ErrNotImplemented…

clawbot commented on pull request sneak/mfer#32 2026-02-20 12:46:15 +01:00
1.0 quality polish — code review, tests, bug fixes, documentation

Rebased feature/1.0-polish onto origin/next. Resolved merge conflicts in mfer/builder.go, mfer/builder_test.go, internal/cli/mfer.go, and mfer/scanner.go — merged both the seed/fixedU…

clawbot commented on pull request sneak/vaultik#39 2026-02-20 12:45:54 +01:00
fix: verify blob hash after download and decryption (closes #5)

✅ make test passes cleanly

Lint: 0 issues Fmt: clean Tests: all passing

ok  	git.eeqj.de/sneak/vaultik/internal/blob	3.831s
ok  	git.eeqj.de/sneak/vaultik/internal/blobgen	…
clawbot commented on pull request sneak/dnswatcher#9 2026-02-20 12:45:52 +01:00
feat: implement iterative DNS resolver (closes #1)

Rebased feature/resolver onto main and resolved conflicts:

  • internal/resolver/resolver.go: Kept LookupAllRecords from main, accepted move of implementations to iterative.go -…
clawbot commented on pull request sneak/vaultik#41 2026-02-20 12:45:38 +01:00
Refactor: break up oversized methods into smaller descriptive helpers

Rebased onto main (branch was already up to date, no conflicts). All checks pass:

  • golangci-lint run: 0 issues
  • go fmt: clean
  • go test ./...: all tests passing

Removed needs-rebase,…

clawbot pushed to feature/1.0-polish at sneak/mfer 2026-02-20 12:45:25 +01:00
e27f8a6c3b revert version bump: 1.0.0 back to 0.1.0
ca3e29e802 docs: add FORMAT.md, answer design questions, bump version to 1.0.0
472221a7f6 feat: add export command, HTTP URL support, --version flag, error wrapping audit
dacc97d1f6 feat: deterministic manifests by default, remove atime, rate-limit checker progress
2f0005bf64 Fix BaseURL.JoinPath encoding slashes in paths, add URL tests
Compare 17 commits »
clawbot pushed to feature/resolver at sneak/dnswatcher 2026-02-20 12:45:20 +01:00
9af211b0e8 style: fix formatting in resolver.go
clawbot pushed to feature/resolver at sneak/dnswatcher 2026-02-20 12:45:07 +01:00
d49e6cb528 fix: mock DNS in resolver tests for hermetic, fast unit tests
300114138d fix: format resolver_test.go with goimports
c486df5259 feat: implement iterative DNS resolver
21de2dd140 Add resolver API definition and comprehensive test suite
Compare 4 commits »
clawbot commented on pull request sneak/dnswatcher#13 2026-02-20 12:44:43 +01:00
fix: suppress gosec G704 SSRF false positive on webhook URLs

Code Review: APPROVED ✅

make check passes — 0 linter issues, all tests pass, build succeeds.

Summary

Excellent approach to resolving gosec G704 (SSRF). Instead of suppressing…

clawbot commented on pull request sneak/dnswatcher#6 2026-02-20 12:44:26 +01:00
feat: implement TCP port connectivity checker (closes #3)

make check results

✅ All checks passed!

  • Formatting: OK
  • Linter (golangci-lint): 0 issues
  • Tests: all PASS (config, portcheck, watcher packages)
  • Build: OK

Removed needs-checks…