Block a user
s3.part_size is documented and accepted but has no effect
Implemented in sneak/vaultik#262: s3.part_size now reaches the uploader for both storage_url and the s3.* fields, and a part size below 5MiB or above 5GiB fails at…
Pass s3.part_size to the multipart uploader
Limit how much fetch and check read for a manifest or a file (closes #168)
Review failed.
internal/cli/fetch_test.go,TestManifestDownloadStopsPastLimit: the test sends the real 258 MiB limit plus 32 MiB to bothfetchandcheck.fetchkeeps two copies of…
yarn install warns three times that workspaces need a private project
Byte limits per client over a minute, an hour and a day
Review failed: one finding.
CloseWriteonupgradedConnininternal/proxy/bodies.gohas no test. Nothing in the repo calls it:ReverseProxytells the app that the client has stopped…
Copy go-bip39 into internal/bip39 (closes #122)
PASS: internal/bip39 is a faithful trimmed copy of go-bip39 v1.1.0 with its licence and word list unchanged, every import has moved to it, and the disclosed lint suppressions and the `pkg/bip85/R…
Compare --require-signature with the key that signed (closes #167)
Review failed.
mfer/serialize.go,signOuter: signing now takes the first key gpg lists for the--sign-keyvalue in the public keyring and signs with that key's fingerprint. When the…
Tag the image build in the checklist's script/cibuild item (closes #125)
- Fixed: the
script/cibuilditem now also says$versioncomes fromgit describe --tags --always --dirty(unknownif empty), assigned on its own line before the build like$tag; the…
Find why the Hetzner targets fail in the browser, and log every failed check to the console
Hetzner checks answer again; failed checks go to the console
Byte limits per client over a minute, an hour and a day
- What a WebSocket carries is now counted each way, as
SWWAF_BYTES_COUNTsays, once it closes, and can ban the client then without cutting it;TestWebSocketBytesAreCountedOnceItClosescovers…
Nothing limits how much fetch and check read from a server for a manifest or a file
Built in sneak/mfer#172. The library refuses a manifest larger than MaxManifestSize (258 MiB), fetch and check stop downloading a manifest at that point, and…
Limit how much fetch and check read for a manifest or a file (closes #168)
Hetzner checks answer again; failed checks go to the console
Review passed.
- Judgement call: the debug log no longer lists checks the page does not record. That loses nothing a reader relied on: first-round failures show again from the second round,…