s3.part_size is documented and accepted but has no effect #232

Open
opened 2026-10-06 01:49:48 +02:00 by clawbot · 1 comment
Collaborator

config.example.yml:288-292 and the config init template (internal/cli/config.go:199) document s3.part_size as the multipart upload part size, default 5MB. internal/config/config.go:36, :207 and :299-300 load it and default it. The S3 client never reads it, though: the uploader's part size is fixed at 10 MB (internal/s3/client.go:116-121). Traced on next at 0700901.

Definition of done

  1. The configured s3.part_size reaches the uploader, and the documented default holds.
  2. Values outside what S3 accepts (a part smaller than 5 MiB) are rejected when the config loads, with an error.
  3. A test asserts that the uploader is built with the configured part size.
  4. make check passes.

Model: fable-5-1 (audit); opus-5-5 (issue)

`config.example.yml:288-292` and the `config init` template (`internal/cli/config.go:199`) document `s3.part_size` as the multipart upload part size, default 5MB. `internal/config/config.go:36`, `:207` and `:299-300` load it and default it. The S3 client never reads it, though: the uploader's part size is fixed at 10 MB (`internal/s3/client.go:116-121`). Traced on `next` at `0700901`. ## Definition of done 1. The configured `s3.part_size` reaches the uploader, and the documented default holds. 2. Values outside what S3 accepts (a part smaller than 5 MiB) are rejected when the config loads, with an error. 3. A test asserts that the uploader is built with the configured part size. 4. `make check` passes. Model: fable-5-1 (audit); opus-5-5 (issue)
clawbot self-assigned this 2026-10-06 01:49:48 +02:00
Author
Collaborator

Implemented in #262: s3.part_size now reaches the uploader for both storage_url and the s3.* fields, and a part size below 5MiB or above 5GiB fails at config load. The docs now give the default as 5MiB, since 5MB is read as 5,000,000 bytes.

Model: opus-5-5

Implemented in https://git.eeqj.de/sneak/vaultik/pulls/262: `s3.part_size` now reaches the uploader for both `storage_url` and the `s3.*` fields, and a part size below 5MiB or above 5GiB fails at config load. The docs now give the default as `5MiB`, since `5MB` is read as 5,000,000 bytes. Model: opus-5-5
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/vaultik#232