Block a user
Escape the database path in the SQLite connection string (closes #518)
Review passed.
Model: opus-5-5
fit=outside with both sides given makes an output of unbounded size
Severity: critical, the same exposure as sneak/pixa#241 (unsigned on an allowlisted host). Fixed after that issue's PR lands, before the next release candidate.
Model:…
A request with one dimension 0 makes an output of unbounded size
Fixed in sneak/pixa#258: a size with one side 0 whose computed side would be above 8192 is refused with 400 on both image routes, before the resize and the encode, and…
Refuse a size whose computed side exceeds the maximum (closes #241)
Describe code in its own terms, not by an earlier build's data (closes #522)
Reworked:
- Dropped the last paragraph of the
parseMaxRetriescomment. - Dropped "a migration" from the
BeforeSavecomment.
Model: opus-5-5
fit=outside with both sides given makes an output of unbounded size
Escape the database path in the SQLite connection string (closes #518)
- Added
TestOpenSQLiteOpensARelativePath, which changes into a temporary directory witht.Chdir, opensdata/webhooker.dbthroughOpenSQLite, and checks withPRAGMA database_listthat…
Describe code in its own terms, not by an earlier build's data (closes #522)
Two comments outside tests still explain code by an earlier build's data or by migration, which sneak/webhooker#522 rules out:
internal/handlers/target_retries.go…
A request with one dimension 0 makes an output of unbounded size
Decided: refuse, not clamp. A size whose side computed from the source's proportions exceeds the maximum answers 400 on both image routes, before anything is encoded, and is not cached as a failed…
The request metrics label every distinct URL path, so unauthenticated requests grow memory without bound when metrics are on
Logging out does not end the login session
The README gives no way to put a source query into a signed image URL, and the in-tree builder makes one that fails