clawbot commented on pull request sneak/webhooker#523 2026-10-13 09:29:30 +02:00
Escape the database path in the SQLite connection string (closes #518)

Review passed.

Model: opus-5-5

clawbot commented on issue sneak/pixa#257 2026-10-13 09:24:27 +02:00
fit=outside with both sides given makes an output of unbounded size

Severity: critical, the same exposure as sneak/pixa#241 (unsigned on an allowlisted host). Fixed after that issue's PR lands, before the next release candidate.

Model:…

clawbot commented on issue sneak/pixa#241 2026-10-13 09:22:31 +02:00
A request with one dimension 0 makes an output of unbounded size

Fixed in sneak/pixa#258: a size with one side 0 whose computed side would be above 8192 is refused with 400 on both image routes, before the resize and the encode, and…

clawbot created pull request sneak/pixa#258 2026-10-13 09:22:23 +02:00
Refuse a size whose computed side exceeds the maximum (closes #241)
clawbot pushed to issue-239-destination-marker at sneak/vaultik 2026-10-13 09:10:52 +02:00
d78e2c47c8 Refuse a backup destination an unplugged volume left empty (closes #239)
94412d9ef3 Stop remote info counting a non-blob file under blobs/ (closes #295)
Compare 2 commits »
clawbot pushed to issue-302-remove-blob-temp-file at sneak/vaultik 2026-10-13 09:10:43 +02:00
f2ed1c4868 Remove the blob temp file when a backup stops part-way (closes #302)
94412d9ef3 Stop remote info counting a non-blob file under blobs/ (closes #295)
167c0a0746 Make snapshot remove fail for an unknown snapshot ID (closes #293)
Compare 3 commits »
clawbot commented on pull request sneak/webhooker#524 2026-10-13 09:10:31 +02:00
Describe code in its own terms, not by an earlier build's data (closes #522)

Reworked:

  1. Dropped the last paragraph of the parseMaxRetries comment.
  2. Dropped "a migration" from the BeforeSave comment.

Model: opus-5-5

clawbot pushed to issue-522-comments-own-terms at sneak/webhooker 2026-10-13 09:10:23 +02:00
7e9e441d42 Describe code in its own terms, not by an earlier build's data (closes #522)
e73beb20df Remove upgrade and older-build text from the README (closes #520)
Compare 2 commits »
clawbot pushed to issue-241-bound-computed-side at sneak/pixa 2026-10-13 09:08:18 +02:00
3c40863c2e Refuse a size whose computed side exceeds the maximum (closes #241)
ba1930c5cc Test that a size whose computed side exceeds the maximum is refused (part of #241)
Compare 2 commits »
clawbot opened issue sneak/pixa#257 2026-10-13 09:00:18 +02:00
fit=outside with both sides given makes an output of unbounded size
clawbot pushed to issue-241-bound-computed-side at sneak/pixa 2026-10-13 09:00:04 +02:00
0bc32bcd7b Refuse a size whose computed side exceeds the maximum (closes #241)
clawbot commented on pull request sneak/webhooker#523 2026-10-13 09:00:02 +02:00
Escape the database path in the SQLite connection string (closes #518)
  1. Added TestOpenSQLiteOpensARelativePath, which changes into a temporary directory with t.Chdir, opens data/webhooker.db through OpenSQLite, and checks with PRAGMA database_list that…
clawbot pushed to issue-518-escape-sqlite-path at sneak/webhooker 2026-10-13 08:59:46 +02:00
0ef53a4e15 Escape the database path in the SQLite connection string (closes #518)
e73beb20df Remove upgrade and older-build text from the README (closes #520)
Compare 2 commits »
clawbot pushed to issue-241-bound-computed-side at sneak/pixa 2026-10-13 08:56:29 +02:00
c8d4b9fd13 Test that a size whose computed side exceeds the maximum is refused (part of #241)
clawbot created branch issue-241-bound-computed-side in sneak/pixa 2026-10-13 08:56:29 +02:00
clawbot commented on pull request sneak/webhooker#524 2026-10-13 08:51:11 +02:00
Describe code in its own terms, not by an earlier build's data (closes #522)

Two comments outside tests still explain code by an earlier build's data or by migration, which sneak/webhooker#522 rules out:

  1. internal/handlers/target_retries.go…
clawbot commented on issue sneak/pixa#241 2026-10-13 08:47:42 +02:00
A request with one dimension 0 makes an output of unbounded size

Decided: refuse, not clamp. A size whose side computed from the source's proportions exceeds the maximum answers 400 on both image routes, before anything is encoded, and is not cached as a failed…

clawbot opened issue sneak/pixa#254 2026-10-13 08:46:11 +02:00
The request metrics label every distinct URL path, so unauthenticated requests grow memory without bound when metrics are on
clawbot opened issue sneak/pixa#256 2026-10-13 08:46:11 +02:00
Logging out does not end the login session
clawbot opened issue sneak/pixa#255 2026-10-13 08:46:11 +02:00
The README gives no way to put a source query into a signed image URL, and the in-tree builder makes one that fails