Two code comments explain behaviour by what an earlier build left behind #522

Open
opened 2026-10-13 07:10:38 +02:00 by clawbot · 1 comment
Collaborator

Severity: low (comments only; no behaviour change).

Two Go comments explain code by what an earlier build left behind. webhooker is pre-1.0 with no installed base, so they describe a situation that does not exist:

  • internal/database/sqlite_open.go, the comment on reserveSQLiteFile: "Chmod of a file that already exists is what tightens a data directory an earlier build left at 0644 … without any migration machinery."
  • internal/session/session.go, the comment on expired: "A session that claims to be authenticated but carries no timestamps predates this check; it is treated as expired …"

Done when both comments say what the code does in its own terms (the mode is set on every open, whoever created the file; a session without timestamps is treated as expired), with no mention of earlier builds, and no other comment outside tests explains code by an earlier build's data. Comments only, one PR to next.

Model: opus-5-5

Severity: low (comments only; no behaviour change). Two Go comments explain code by what an earlier build left behind. webhooker is pre-1.0 with no installed base, so they describe a situation that does not exist: - `internal/database/sqlite_open.go`, the comment on `reserveSQLiteFile`: "Chmod of a file that already exists is what tightens a data directory an earlier build left at 0644 … without any migration machinery." - `internal/session/session.go`, the comment on `expired`: "A session that claims to be authenticated but carries no timestamps predates this check; it is treated as expired …" Done when both comments say what the code does in its own terms (the mode is set on every open, whoever created the file; a session without timestamps is treated as expired), with no mention of earlier builds, and no other comment outside tests explains code by an earlier build's data. Comments only, one PR to `next`. Model: opus-5-5
clawbot self-assigned this 2026-10-13 07:10:38 +02:00
Author
Collaborator

Done in #524. Both named comments now say what the code does in its own terms. The same search turned up eight more comments that justified code by older rows or files; they are reworded the same way. Comments that only describe how the code used to behave are left alone (judgement call, listed in the PR).

Model: opus-5-5

Done in https://git.eeqj.de/sneak/webhooker/pulls/524. Both named comments now say what the code does in its own terms. The same search turned up eight more comments that justified code by older rows or files; they are reworded the same way. Comments that only describe how the code used to behave are left alone (judgement call, listed in the PR). Model: opus-5-5
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/webhooker#522